Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 913353002: Update paper-checkbox to 0.5.4. (Closed)

Created:
5 years, 10 months ago by Oren Blasberg
Modified:
5 years, 10 months ago
Reviewers:
Jeremy Klein, michaelpg
CC:
chromium-reviews, michaelpg+watch-polymer_chromium.org, Jeremy Klein
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update paper-checkbox to 0.5.4. The latest <paper-checkbox> matches the Material Design spec. The MD-Settings page will make use of this button in a follow-up CL. Since paper-checkbox isn't currently used in Chromium there shouldn't be any side effects for this change. BUG=457513 NOPRESUBMIT=true Committed: https://crrev.com/85a2fa2ad623696e1f182f7bfa11152eae63d542 Cr-Commit-Position: refs/heads/master@{#316321}

Patch Set 1 #

Patch Set 2 : Did a git pull #

Patch Set 3 : Did gclient sync #

Patch Set 4 : Updating line endings on css/html files #

Patch Set 5 : Applying sed to remove cr's. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -451 lines) Patch
M third_party/polymer/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/components-chromium/paper-checkbox/.bower.json View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/polymer/components-chromium/paper-checkbox/bower.json View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/polymer/components-chromium/paper-checkbox/demo.html View 3 chunks +57 lines, -41 lines 0 comments Download
M third_party/polymer/components-chromium/paper-checkbox/paper-checkbox.css View 1 2 3 4 3 chunks +44 lines, -163 lines 0 comments Download
M third_party/polymer/components-chromium/paper-checkbox/paper-checkbox.html View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/polymer/components-chromium/paper-checkbox/paper-checkbox-extracted.js View 1 chunk +4 lines, -8 lines 0 comments Download
M third_party/polymer/components/paper-checkbox/.bower.json View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/polymer/components/paper-checkbox/bower.json View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/polymer/components/paper-checkbox/demo.html View 3 chunks +57 lines, -41 lines 0 comments Download
M third_party/polymer/components/paper-checkbox/paper-checkbox.css View 1 2 3 4 3 chunks +44 lines, -163 lines 0 comments Download
M third_party/polymer/components/paper-checkbox/paper-checkbox.html View 1 2 3 4 3 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 27 (12 generated)
Oren Blasberg
5 years, 10 months ago (2015-02-12 00:18:56 UTC) #2
Jeremy Klein
lgtm
5 years, 10 months ago (2015-02-12 00:27:01 UTC) #4
Jeremy Klein
lgtm
5 years, 10 months ago (2015-02-12 00:27:02 UTC) #5
michaelpg
lgtm Since paper-checkbox extends paper-radio-button, let's make sure we update paper-radio-button in a follow-on CL. ...
5 years, 10 months ago (2015-02-12 01:05:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913353002/1
5 years, 10 months ago (2015-02-12 01:06:21 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/57952) ios_rel_device_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 10 months ago (2015-02-12 01:09:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913353002/20001
5 years, 10 months ago (2015-02-12 01:40:51 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/57969) ios_rel_device_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 10 months ago (2015-02-12 01:43:45 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913353002/40001
5 years, 10 months ago (2015-02-12 02:05:05 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja_ng/builds/9913)
5 years, 10 months ago (2015-02-12 02:07:54 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913353002/60001
5 years, 10 months ago (2015-02-12 19:19:49 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/23122) ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 10 months ago (2015-02-12 19:23:51 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913353002/80001
5 years, 10 months ago (2015-02-13 23:06:42 UTC) #25
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-02-13 23:26:07 UTC) #26
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 23:26:50 UTC) #27
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/85a2fa2ad623696e1f182f7bfa11152eae63d542
Cr-Commit-Position: refs/heads/master@{#316321}

Powered by Google App Engine
This is Rietveld 408576698