win: Implementation of CrashReportDatabase for Windows (for C++ Windows readability review)

client/crash_report_database_test.cc

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 18 matching lines @@
   struct stat st;
   return lstat(path.value().c_str(), &st) == 0;
 #elif defined(OS_WIN)
   struct _stat st;
   return _wstat(path.value().c_str(), &st) == 0;
 #else
 #error "Not implemented"
 #endif
 }
 
-void CreateFile(const base::FilePath& path) {
-  FileHandle handle = LoggingOpenFileForWrite(path,
-                                              FileWriteMode::kCreateOrFail,
-                                              FilePermissions::kWorldReadable);
-#if defined(OS_POSIX)
-  ASSERT_GE(handle, 0);
-#elif defined(OS_WIN)
-  ASSERT_NE(handle, nullptr);
-#endif
-  ASSERT_TRUE(
-      LoggingWriteFile(handle, path.value().c_str(), path.value().length()));
-  ASSERT_TRUE(LoggingCloseFile(handle));
-}
+class CrashReportDatabaseTest : public testing::Test {
+ public:
+  CrashReportDatabaseTest() {
+  }
 
-class CrashReportDatabaseTest : public testing::Test {
  protected:
   // testing::Test:
   void SetUp() override {
     db_ = CrashReportDatabase::Initialize(path());
-    ASSERT_TRUE(db_.get());
+    ASSERT_TRUE(db_);
   }
 
   void ResetDatabase() {
     db_.reset();
   }
 
-  CrashReportDatabase* db() const { return db_.get(); }
+  CrashReportDatabase* db() { return db_.get(); }
   const base::FilePath& path() const { return temp_dir_.path(); }
 
   void CreateCrashReport(CrashReportDatabase::Report* report) {
-    CrashReportDatabase::NewReport* new_report;
-    EXPECT_EQ(CrashReportDatabase::kNoError,
+    CrashReportDatabase::NewReport* new_report = nullptr;
+    ASSERT_EQ(CrashReportDatabase::kNoError,
               db_->PrepareNewCrashReport(&new_report));
     const char kTest[] = "test";
     ASSERT_TRUE(LoggingWriteFile(new_report->handle, kTest, sizeof(kTest)));
 
     UUID uuid;
     EXPECT_EQ(CrashReportDatabase::kNoError,
               db_->FinishedWritingCrashReport(new_report, &uuid));
 
     EXPECT_EQ(CrashReportDatabase::kNoError,
               db_->LookUpCrashReport(uuid, report));
     ExpectPreparedCrashReport(*report);
     ASSERT_TRUE(FileExistsAtPath(report->file_path));
   }
 
   void UploadReport(const UUID& uuid, bool successful, const std::string& id) {
     const CrashReportDatabase::Report* report = nullptr;
-    EXPECT_EQ(CrashReportDatabase::kNoError,
+    ASSERT_EQ(CrashReportDatabase::kNoError,
               db_->GetReportForUploading(uuid, &report));
-    EXPECT_TRUE(report);
     EXPECT_NE(UUID(), report->uuid);
     EXPECT_FALSE(report->file_path.empty());
     EXPECT_TRUE(FileExistsAtPath(report->file_path))
         << report->file_path.value();
     EXPECT_GT(report->creation_time, 0);
     EXPECT_EQ(CrashReportDatabase::kNoError,
               db_->RecordUploadAttempt(report, successful, id));
   }
 
   void ExpectPreparedCrashReport(const CrashReportDatabase::Report& report) {
     EXPECT_NE(UUID(), report.uuid);
     EXPECT_FALSE(report.file_path.empty());
     EXPECT_TRUE(FileExistsAtPath(report.file_path)) << report.file_path.value();
     EXPECT_TRUE(report.id.empty());
     EXPECT_GT(report.creation_time, 0);
     EXPECT_FALSE(report.uploaded);
     EXPECT_EQ(0, report.last_upload_attempt_time);
     EXPECT_EQ(0, report.upload_attempts);
   }
 
   void RelocateDatabase() {
     ResetDatabase();
     temp_dir_.Rename();
     SetUp();
   }
 
  private:
   ScopedTempDir temp_dir_;
   scoped_ptr<CrashReportDatabase> db_;
+
+  DISALLOW_COPY_AND_ASSIGN(CrashReportDatabaseTest);
 };
 
 TEST_F(CrashReportDatabaseTest, Initialize) {
   // Initialize the database for the first time, creating it.
   EXPECT_TRUE(db());
 
   // Close and reopen the database at the same path.
   ResetDatabase();
   EXPECT_FALSE(db());
   auto db = CrashReportDatabase::Initialize(path());
-  EXPECT_TRUE(db.get());
+  ASSERT_TRUE(db);
 
   std::vector<const CrashReportDatabase::Report> reports;
   EXPECT_EQ(CrashReportDatabase::kNoError, db->GetPendingReports(&reports));
   EXPECT_TRUE(reports.empty());
+  reports.clear();
   EXPECT_EQ(CrashReportDatabase::kNoError, db->GetCompletedReports(&reports));
   EXPECT_TRUE(reports.empty());
 }
 
 TEST_F(CrashReportDatabaseTest, NewCrashReport) {
   CrashReportDatabase::NewReport* new_report;
   EXPECT_EQ(CrashReportDatabase::kNoError,
             db()->PrepareNewCrashReport(&new_report));
   EXPECT_TRUE(FileExistsAtPath(new_report->path)) << new_report->path.value();
   UUID uuid;
@@ skipping 11 matching lines @@
   ASSERT_EQ(1u, reports.size());
   EXPECT_EQ(report.uuid, reports[0].uuid);
 
   reports.clear();
   EXPECT_EQ(CrashReportDatabase::kNoError,
             db()->GetCompletedReports(&reports));
   EXPECT_TRUE(reports.empty());
 }
 
 TEST_F(CrashReportDatabaseTest, ErrorWritingCrashReport) {
-  CrashReportDatabase::NewReport* new_report;
-  EXPECT_EQ(CrashReportDatabase::kNoError,
+  CrashReportDatabase::NewReport* new_report = nullptr;
+  ASSERT_EQ(CrashReportDatabase::kNoError,
             db()->PrepareNewCrashReport(&new_report));
   base::FilePath new_report_path = new_report->path;
   EXPECT_TRUE(FileExistsAtPath(new_report_path)) << new_report_path.value();
   EXPECT_EQ(CrashReportDatabase::kNoError,
             db()->ErrorWritingCrashReport(new_report));
   EXPECT_FALSE(FileExistsAtPath(new_report_path)) << new_report_path.value();
 }
 
 TEST_F(CrashReportDatabaseTest, LookUpCrashReport) {
   UUID uuid;
 
   {
     CrashReportDatabase::Report report;
     CreateCrashReport(&report);
     uuid = report.uuid;
   }
 
   {
     CrashReportDatabase::Report report;
     EXPECT_EQ(CrashReportDatabase::kNoError,
               db()->LookUpCrashReport(uuid, &report));
     EXPECT_EQ(uuid, report.uuid);
     EXPECT_NE(std::string::npos, report.file_path.value().find(path().value()));
-    EXPECT_EQ("", report.id);
+    EXPECT_EQ(std::string(), report.id);
     EXPECT_FALSE(report.uploaded);
     EXPECT_EQ(0, report.last_upload_attempt_time);
     EXPECT_EQ(0, report.upload_attempts);
   }
 
   UploadReport(uuid, true, "test");
 
   {
     CrashReportDatabase::Report report;
     EXPECT_EQ(CrashReportDatabase::kNoError,
               db()->LookUpCrashReport(uuid, &report));
     EXPECT_EQ(uuid, report.uuid);
     EXPECT_NE(std::string::npos, report.file_path.value().find(path().value()));
     EXPECT_EQ("test", report.id);
     EXPECT_TRUE(report.uploaded);
     EXPECT_NE(0, report.last_upload_attempt_time);
     EXPECT_EQ(1, report.upload_attempts);
   }
 }
 
 TEST_F(CrashReportDatabaseTest, RecordUploadAttempt) {
   std::vector<CrashReportDatabase::Report> reports(3);
   CreateCrashReport(&reports[0]);
   CreateCrashReport(&reports[1]);
   CreateCrashReport(&reports[2]);
 
   // Record two attempts: one successful, one not.
   UploadReport(reports[1].uuid, false, "");

[Peter Kasting, 2015/02/14 00:24:23]

Nit: Some more "" -> std::string() (multiple places)

[scottmg, 2015/02/14 00:42:45]

Done.

   UploadReport(reports[2].uuid, true, "abc123");
 
   std::vector<CrashReportDatabase::Report> query(3);
 
   EXPECT_EQ(CrashReportDatabase::kNoError,
             db()->LookUpCrashReport(reports[0].uuid, &query[0]));
   EXPECT_EQ(CrashReportDatabase::kNoError,
             db()->LookUpCrashReport(reports[1].uuid, &query[1]));
   EXPECT_EQ(CrashReportDatabase::kNoError,
             db()->LookUpCrashReport(reports[2].uuid, &query[2]));
 
-  EXPECT_EQ("", query[0].id);
-  EXPECT_EQ("", query[1].id);
+  EXPECT_EQ(std::string(), query[0].id);
+  EXPECT_EQ(std::string(), query[1].id);
   EXPECT_EQ("abc123", query[2].id);
 
   EXPECT_FALSE(query[0].uploaded);
   EXPECT_FALSE(query[1].uploaded);
   EXPECT_TRUE(query[2].uploaded);
 
   EXPECT_EQ(0, query[0].last_upload_attempt_time);
   EXPECT_NE(0, query[1].last_upload_attempt_time);
   EXPECT_NE(0, query[2].last_upload_attempt_time);
 
@@ skipping 90 matching lines @@
   ASSERT_EQ(1u, completed.size());
 
   for (const auto& report : pending)
     EXPECT_NE(report_1_uuid, report.uuid);
   EXPECT_EQ(report_1_uuid, completed[0].uuid);
   EXPECT_EQ("report1", completed[0].id);
   EXPECT_EQ(true, completed[0].uploaded);
   EXPECT_GT(completed[0].last_upload_attempt_time, 0);
   EXPECT_EQ(1, completed[0].upload_attempts);
 
-  const CrashReportDatabase::Report completed_report_1 = completed[0];
-
   // Fail to upload one report.
   UploadReport(report_2_uuid, false, "");
 
   pending.clear();
   EXPECT_EQ(CrashReportDatabase::kNoError,
             db()->GetPendingReports(&pending));
   completed.clear();
   EXPECT_EQ(CrashReportDatabase::kNoError,
             db()->GetCompletedReports(&completed));
 
@@ skipping 100 matching lines @@
   CrashReportDatabase::Report report;
   EXPECT_EQ(CrashReportDatabase::kNoError,
             db()->LookUpCrashReport(uuid, &report));
   ExpectPreparedCrashReport(report);
   EXPECT_TRUE(FileExistsAtPath(report.file_path)) << report.file_path.value();
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad