Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 913223009: Avoid crash in HistoryNode::CloneAndReplace with out-of-process iframes. (Closed)

Created:
5 years, 10 months ago by Charlie Reis
Modified:
5 years, 10 months ago
Reviewers:
alexmos
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid crash in HistoryNode::CloneAndReplace with out-of-process iframes. BUG=426953 TEST=See bug for repro steps. Committed: https://crrev.com/0040d3460f2bdb614e06caa3c4066ab898d1a4a5 Cr-Commit-Position: refs/heads/master@{#316961}

Patch Set 1 #

Total comments: 2

Patch Set 2 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M content/browser/site_per_process_browsertest.cc View 1 1 chunk +35 lines, -0 lines 0 comments Download
M content/renderer/history_entry.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Charlie Reis
Alex: This should work around the HistoryNode crash until we can handle it in the ...
5 years, 10 months ago (2015-02-18 23:41:20 UTC) #2
alexmos
LGTM. Glad to see this fixed, and thanks for writing a test for it! https://codereview.chromium.org/913223009/diff/1/content/browser/site_per_process_browsertest.cc ...
5 years, 10 months ago (2015-02-19 00:33:08 UTC) #3
Charlie Reis
Great, thanks. https://codereview.chromium.org/913223009/diff/1/content/browser/site_per_process_browsertest.cc File content/browser/site_per_process_browsertest.cc (right): https://codereview.chromium.org/913223009/diff/1/content/browser/site_per_process_browsertest.cc#newcode1325 content/browser/site_per_process_browsertest.cc:1325: GURL main_url(embedded_test_server()->GetURL( On 2015/02/19 00:33:08, alexmos wrote: ...
5 years, 10 months ago (2015-02-19 00:36:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913223009/20001
5 years, 10 months ago (2015-02-19 00:38:15 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-19 01:42:50 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 01:43:19 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/0040d3460f2bdb614e06caa3c4066ab898d1a4a5
Cr-Commit-Position: refs/heads/master@{#316961}

Powered by Google App Engine
This is Rietveld 408576698