Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 913203007: Estimate content type from url when it's not available. (Closed)

Created:
5 years, 10 months ago by yawano
Modified:
5 years, 10 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Estimate content type from url when it's not available. BUG=459326 TEST=Manually tested as described in the issue. Committed: https://crrev.com/4725bfa6da3bc5a03c22c6e381583f403f8d3f90 Cr-Commit-Position: refs/heads/master@{#317007}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Add background color to list thumbnail icon. #

Total comments: 4

Patch Set 4 : Address comments. #

Patch Set 5 : Fix type annotation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/image_loader/request.js View 1 2 3 4 4 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
yawano
PTAL. Thank you! Note: When you try to check this CL on local, please remember ...
5 years, 10 months ago (2015-02-18 10:28:12 UTC) #2
yawano
Added new patch to set background-color of list thumbnail icon. PTAL. Thank you!
5 years, 10 months ago (2015-02-18 10:39:42 UTC) #3
fukino
lgtm with nits. https://codereview.chromium.org/913203007/diff/40001/ui/file_manager/image_loader/request.js File ui/file_manager/image_loader/request.js (right): https://codereview.chromium.org/913203007/diff/40001/ui/file_manager/image_loader/request.js#newcode290 ui/file_manager/image_loader/request.js:290: this.extractExtension_(url)]; Is reading ExtensionContentTypeMap[null] intended? https://codereview.chromium.org/913203007/diff/40001/ui/file_manager/image_loader/request.js#newcode349 ...
5 years, 10 months ago (2015-02-18 10:45:22 UTC) #4
yawano
Thank you! https://codereview.chromium.org/913203007/diff/40001/ui/file_manager/image_loader/request.js File ui/file_manager/image_loader/request.js (right): https://codereview.chromium.org/913203007/diff/40001/ui/file_manager/image_loader/request.js#newcode290 ui/file_manager/image_loader/request.js:290: this.extractExtension_(url)]; On 2015/02/18 10:45:22, fukino wrote: > ...
5 years, 10 months ago (2015-02-18 11:32:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913203007/80001
5 years, 10 months ago (2015-02-19 07:39:54 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-02-19 08:22:55 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 08:23:28 UTC) #10
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/4725bfa6da3bc5a03c22c6e381583f403f8d3f90
Cr-Commit-Position: refs/heads/master@{#317007}

Powered by Google App Engine
This is Rietveld 408576698