Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1190)

Unified Diff: media/video/capture/win/capability_list_win.h

Issue 913183006: Use BITMAPINFOHEADER from capture capability enumeration when using MJPG (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changed so that the SinkInputBit now uses the BITMAPINFOHEADER from capabilities enumeration. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/video/capture/win/capability_list_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/video/capture/win/capability_list_win.h
diff --git a/media/video/capture/win/capability_list_win.h b/media/video/capture/win/capability_list_win.h
index e173439cd4d33c72e83ad54d183cee10a310af4c..5ff2fd8ad25ee852d67ce83dc211a1aebb1e2a43 100644
--- a/media/video/capture/win/capability_list_win.h
+++ b/media/video/capture/win/capability_list_win.h
@@ -10,6 +10,7 @@
#define MEDIA_VIDEO_CAPTURE_WIN_CAPABILITY_LIST_WIN_H_
#include <list>
+#include <windows.h>
#include "media/video/capture/video_capture_types.h"
@@ -18,14 +19,27 @@ namespace media {
struct CapabilityWin {
CapabilityWin(int index, const VideoCaptureFormat& format)
: stream_index(index), supported_format(format) {}
- int stream_index;
- VideoCaptureFormat supported_format;
+
+ // Used by the DirectShow implementation VideoCaptureDeviceWin.
tommi (sloooow) - chröme 2015/02/13 14:50:09 Used by VideoCaptureDeviceWin (?)
+ CapabilityWin(int index, const VideoCaptureFormat& format,
+ const BITMAPINFOHEADER& info_header)
+ : stream_index(index),
+ supported_format(format),
+ info_header(info_header) {
+ }
+
+ const int stream_index;
+ const VideoCaptureFormat supported_format;
+
+ // |info_header| is only valid if DirectShow is used.
+ const BITMAPINFOHEADER info_header;
tommi (sloooow) - chröme 2015/02/13 14:50:09 nice constness
};
typedef std::list<CapabilityWin> CapabilityList;
-CapabilityWin GetBestMatchedCapability(const VideoCaptureFormat& requested,
- const CapabilityList& capabilities);
+const CapabilityWin& GetBestMatchedCapability(
+ const VideoCaptureFormat& requested,
+ const CapabilityList& capabilities);
} // namespace media
« no previous file with comments | « no previous file | media/video/capture/win/capability_list_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698