Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 913183005: Inline the ParseInfo structure as parameters to the Parser constructor. (Closed)

Created:
5 years, 10 months ago by titzer
Modified:
5 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Inline the ParseInfo structure as parameters to the Parser constructor. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/d9790bc7ed8adb422a857415dbd564c077634330 Cr-Commit-Position: refs/heads/master@{#26606}

Patch Set 1 #

Patch Set 2 : pass hash seed too #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -64 lines) Patch
M src/background-parsing-task.cc View 1 1 chunk +5 lines, -4 lines 0 comments Download
M src/parser.h View 1 2 chunks +3 lines, -23 lines 0 comments Download
M src/parser.cc View 1 3 chunks +18 lines, -5 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 8 chunks +17 lines, -32 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Starzinger
LGTM.
5 years, 10 months ago (2015-02-12 09:27:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913183005/1
5 years, 10 months ago (2015-02-12 09:27:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913183005/20001
5 years, 10 months ago (2015-02-12 09:54:49 UTC) #7
titzer
Committed patchset #3 (id:40001) manually as d9790bc7ed8adb422a857415dbd564c077634330 (presubmit successful).
5 years, 10 months ago (2015-02-12 11:57:17 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 11:57:20 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d9790bc7ed8adb422a857415dbd564c077634330
Cr-Commit-Position: refs/heads/master@{#26606}

Powered by Google App Engine
This is Rietveld 408576698