Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 913183004: Add libssl1.0.0:386 to install-build-deps.sh for naclports (Closed)

Created:
5 years, 10 months ago by Sam Clegg
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add libssl1.0.0:i386 to install-build-deps.sh for naclports Previously we were installing and using libssl0.9.8:i386 which was actually a miss-match with the 1.0.0 headers installed by libssl-dev. TEST=local (remove links and run install-build-deps.sh) Committed: https://crrev.com/6ab44c3694b129131b964cada9feb78a1cc880a2 Cr-Commit-Position: refs/heads/master@{#316319}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -8 lines) Patch
M build/install-build-deps.sh View 1 2 3 4 3 chunks +26 lines, -8 lines 0 comments Download

Messages

Total messages: 24 (10 generated)
Sam Clegg
5 years, 10 months ago (2015-02-11 22:45:16 UTC) #2
bradn
lgtm
5 years, 10 months ago (2015-02-11 22:46:21 UTC) #4
bradn
ah better, still lgtm
5 years, 10 months ago (2015-02-12 00:26:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913183004/40001
5 years, 10 months ago (2015-02-12 00:58:30 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/42159)
5 years, 10 months ago (2015-02-12 01:04:30 UTC) #11
Sam Clegg
+scottmg for build OWNERS
5 years, 10 months ago (2015-02-13 05:15:16 UTC) #13
scottmg
I don't really pretend to understand linux toolchain goop, would either of you like to ...
5 years, 10 months ago (2015-02-13 06:39:59 UTC) #15
Sam Clegg
https://codereview.chromium.org/913183004/diff/40001/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/913183004/diff/40001/build/install-build-deps.sh#newcode424 build/install-build-deps.sh:424: target=/lib/i386-linux-gnu/libcypto.so.1.0.0 On 2015/02/13 06:39:59, scottmg wrote: > "crypto" or ...
5 years, 10 months ago (2015-02-13 17:23:18 UTC) #16
scottmg
otherwise, lgtm https://codereview.chromium.org/913183004/diff/60001/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/913183004/diff/60001/build/install-build-deps.sh#newcode424 build/install-build-deps.sh:424: target=/lib/i386-linux-gnu/libcrypto.so.1.0.0 does this language believe in functions? ...
5 years, 10 months ago (2015-02-13 17:29:09 UTC) #17
Sam Clegg
https://codereview.chromium.org/913183004/diff/60001/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/913183004/diff/60001/build/install-build-deps.sh#newcode424 build/install-build-deps.sh:424: target=/lib/i386-linux-gnu/libcrypto.so.1.0.0 On 2015/02/13 17:29:09, scottmg wrote: > does this ...
5 years, 10 months ago (2015-02-13 22:57:50 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913183004/80001
5 years, 10 months ago (2015-02-13 23:01:23 UTC) #21
scottmg
lgtm!
5 years, 10 months ago (2015-02-13 23:01:35 UTC) #22
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-02-13 23:19:26 UTC) #23
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 23:20:04 UTC) #24
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/6ab44c3694b129131b964cada9feb78a1cc880a2
Cr-Commit-Position: refs/heads/master@{#316319}

Powered by Google App Engine
This is Rietveld 408576698