|
|
DescriptionAdd libssl1.0.0:i386 to install-build-deps.sh for naclports
Previously we were installing and using libssl0.9.8:i386
which was actually a miss-match with the 1.0.0 headers
installed by libssl-dev.
TEST=local (remove links and run install-build-deps.sh)
Committed: https://crrev.com/6ab44c3694b129131b964cada9feb78a1cc880a2
Cr-Commit-Position: refs/heads/master@{#316319}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #
Total comments: 2
Patch Set 4 : #
Total comments: 2
Patch Set 5 : #Messages
Total messages: 24 (10 generated)
sbc@chromium.org changed reviewers: + bradnelson@chromium.org
bradnelson@google.com changed reviewers: + bradnelson@google.com
lgtm
New patchsets have been uploaded after l-g-t-m from bradnelson@google.com
ah better, still lgtm
New patchsets have been uploaded after l-g-t-m from bradnelson@google.com
The CQ bit was checked by sbc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913183004/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
sbc@chromium.org changed reviewers: + scottmg@chromium.org
+scottmg for build OWNERS
scottmg@chromium.org changed reviewers: + cjhopman@chromium.org
I don't really pretend to understand linux toolchain goop, would either of you like to be OWNERS for that sort of thing for build/? Or maybe cjhopman can parse this more fluently. https://codereview.chromium.org/913183004/diff/40001/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/913183004/diff/40001/build/install-build-deps... build/install-build-deps.sh:424: target=/lib/i386-linux-gnu/libcypto.so.1.0.0 "crypto" or "cypto"?
https://codereview.chromium.org/913183004/diff/40001/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/913183004/diff/40001/build/install-build-deps... build/install-build-deps.sh:424: target=/lib/i386-linux-gnu/libcypto.so.1.0.0 On 2015/02/13 06:39:59, scottmg wrote: > "crypto" or "cypto"? Ouch. Thanks. Done.
otherwise, lgtm https://codereview.chromium.org/913183004/diff/60001/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/913183004/diff/60001/build/install-build-deps... build/install-build-deps.sh:424: target=/lib/i386-linux-gnu/libcrypto.so.1.0.0 does this language believe in functions? the libcrypto and libssl blocks look identical except for the two file names.
New patchsets have been uploaded after l-g-t-m from scottmg@chromium.org
https://codereview.chromium.org/913183004/diff/60001/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/913183004/diff/60001/build/install-build-deps... build/install-build-deps.sh:424: target=/lib/i386-linux-gnu/libcrypto.so.1.0.0 On 2015/02/13 17:29:09, scottmg wrote: > does this language believe in functions? the libcrypto and libssl blocks look > identical except for the two file names. Done.
The CQ bit was checked by sbc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913183004/80001
lgtm!
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/6ab44c3694b129131b964cada9feb78a1cc880a2 Cr-Commit-Position: refs/heads/master@{#316319} |