Issue 913173002: Fix shared library build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 913173002: Fix shared library build. (Closed)

Created:
5 years, 10 months ago by Yang

Modified:
5 years, 10 months ago

Reviewers:
vogelheim

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix shared library build. TBR=vogelheim@chromium.org Committed: https://crrev.com/d59202c143668ee2cc68b8ba92d0e5b0993593f3 Cr-Commit-Position: refs/heads/master@{#26581}

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/d8.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Yang

Committed patchset #1 (id:1) manually as d59202c143668ee2cc68b8ba92d0e5b0993593f3.

5 years, 10 months ago (2015-02-11 14:32:35 UTC) #2

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/d59202c143668ee2cc68b8ba92d0e5b0993593f3 Cr-Commit-Position: refs/heads/master@{#26581}

5 years, 10 months ago (2015-02-11 14:32:36 UTC) #3

vogelheim

lgtm Not sure if this is a silly question, but why is src/base/logging.h only included ...

5 years, 10 months ago (2015-02-11 14:35:26 UTC) #4

Yang

5 years, 10 months ago (2015-02-11 14:38:33 UTC) #5

Message was sent while issue was closed.

On 2015/02/11 14:35:26, vogelheim wrote:
> lgtm
> 
> 
> Not sure if this is a silly question, but why is src/base/logging.h only
> included if !V8_SHARED?

V8_SHARED is only set for the shared library build, which can then only use the
stuff exported in include/v8.h, iirc.

Expand Messages | Collapse Messages