Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 913163003: X87: Parsing: Make Scope not know about Isolate. (Closed)

Created:
5 years, 10 months ago by chunyang.dai
Modified:
5 years, 10 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Parsing: Make Scope not know about Isolate. port 5d68529be240a1fc9fcc67c8950ead4baf7604e4 (r26546) original commit message: Parsing: Make Scope not know about Isolate. Scope, like Parser, must be able to operate independent of Isolate and the V8 heap (for background parsing). After the heap-independent phase, there is a heap dependent phase, during which we do operations such as scope anaylysis. This CL makes the phases explicit by not telling Scope about the Isolate too early (during the heap-independent phase, Scope should know nothing about Isolate). This decreases the probability of accidental code changes which would add heap-dependent operations into the heap-independent phase. BUG= R=weiliang.lin@intel.com Committed: https://chromium.googlesource.com/v8/v8/+/75ad4cc265d8d580ca09fe51d2101cd77729379c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/x87/full-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 10 months ago (2015-02-11 15:46:27 UTC) #2
Weiliang
lgtm
5 years, 10 months ago (2015-02-11 15:47:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913163003/1
5 years, 10 months ago (2015-02-11 15:47:44 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/75ad4cc265d8d580ca09fe51d2101cd77729379c Cr-Commit-Position: refs/heads/master@{#26590}
5 years, 10 months ago (2015-02-11 15:51:04 UTC) #6
chunyang.dai
5 years, 10 months ago (2015-02-11 15:51:14 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
75ad4cc265d8d580ca09fe51d2101cd77729379c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698