Add a runtime flag for navigator content utils

Add a runtime flag for navigator content utils

To prepare to remove ENABLE(NAVIGATOR_CONTENT_UTILS) macro, this cl add a runtime flag(NavigatorContentUtils) as *experimental*.
Besides APIs which can enable/disable this feature are added as well.

BUG=N/A

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163413

[gyuyoung-inactive, 2013-12-02 05:11:08]

On 2013/11/28 21:48:06, gyuyoung wrote:

Abarth, I wonder how do you think about this patch.

[abarth-chromium, 2013-12-02 19:45:21]

Is this runtime flag set correctly on Android?  Perhaps we need to introduce the
API in one CL, set it to appropriate values on Android and non-Android, and then
remove the #ifdef.

[gyuyoung-inactive, 2013-12-03 12:09:12]

On 2013/12/02 19:45:21, abarth wrote:
> Is this runtime flag set correctly on Android?  Perhaps we need to introduce
the
> API in one CL, set it to appropriate values on Android and non-Android, and
then
> remove the #ifdef.

I see, let me check how to add a setting API, and use it for android and
non-android.

[gyuyoung-inactive, 2013-12-04 09:22:54]

On 2013/12/03 12:09:12, gyuyoung wrote:
> On 2013/12/02 19:45:21, abarth wrote:
> > Is this runtime flag set correctly on Android?  Perhaps we need to introduce
> the
> > API in one CL, set it to appropriate values on Android and non-Android, and
> then
> > remove the #ifdef.
> 
> I see, let me check how to add a setting API, and use it for android and
> non-android.

Abarth, I add APIs to enable/disable this feature to WebRuntimeFeatures.h
+ BLINK_EXPORT static void enableNavigatorContentUtils(bool);
+ BLINK_EXPORT static bool isNavigatorContentUtilsEnabled();

And, I upload a patch in order to enable it except for android on issue
104123003.
(https://codereview.chromium.org/104123003/)

[gyuyoung-inactive, 2013-12-05 13:31:54]

On 2013/12/04 09:22:54, gyuyoung wrote:
> On 2013/12/03 12:09:12, gyuyoung wrote:
> > On 2013/12/02 19:45:21, abarth wrote:
> > > Is this runtime flag set correctly on Android?  Perhaps we need to
introduce
> > the
> > > API in one CL, set it to appropriate values on Android and non-Android,
and
> > then
> > > remove the #ifdef.
> > 
> > I see, let me check how to add a setting API, and use it for android and
> > non-android.
> 
> Abarth, I add APIs to enable/disable this feature to WebRuntimeFeatures.h
> + BLINK_EXPORT static void enableNavigatorContentUtils(bool);
> + BLINK_EXPORT static bool isNavigatorContentUtilsEnabled();
> 
> And, I upload a patch in order to enable it except for android on issue
> 104123003.
> (https://codereview.chromium.org/104123003/)

Abarth, could you take a look this ? This need to be landed before 104123003
issue.

[abarth-chromium, 2013-12-05 19:07:45]

You need to land this change in three steps:

1) Add an API to set the runtime flag, which does nothing.
2) Land code in Chromium to set the runtime flag appropriately.
3) Remove ifdefs

If we land this CL as written, then we'll have the wrong behavior for a period
of time.

[gyuyoung-inactive, 2013-12-06 00:49:02]

On 2013/12/05 19:07:45, abarth wrote:
> You need to land this change in three steps:
> 
> 1) Add an API to set the runtime flag, which does nothing.
> 2) Land code in Chromium to set the runtime flag appropriately.
> 3) Remove ifdefs
> 
> If we land this CL as written, then we'll have the wrong behavior for a period
> of time.

I see. So, I only add an API to set the runtime flag to this cl. After land this
cl, I will try to land 104593005, then I will remove #ifdef. Are you fine about
my plan ?

[abarth-chromium, 2013-12-09 07:09:47]

On 2013/12/06 00:49:02, gyuyoung wrote:
> I see. So, I only add an API to set the runtime flag to this cl. After land
this
> cl, I will try to land 104593005, then I will remove #ifdef. Are you fine
about
> my plan ?

Yes, sounds good.

[abarth-chromium, 2013-12-09 07:12:55]

https://codereview.chromium.org/91313002/diff/80001/Source/platform/RuntimeEn...
File Source/platform/RuntimeEnabledFeatures.in (right):

https://codereview.chromium.org/91313002/diff/80001/Source/platform/RuntimeEn...
Source/platform/RuntimeEnabledFeatures.in:75: NavigatorContentUtils
status=experimental
I'd leave the status off here.  It's not a simple status because it's shipped on
some platforms but not other.

[gyuyoung-inactive, 2013-12-09 07:35:31]

https://codereview.chromium.org/91313002/diff/80001/Source/platform/RuntimeEn...
File Source/platform/RuntimeEnabledFeatures.in (right):

https://codereview.chromium.org/91313002/diff/80001/Source/platform/RuntimeEn...
Source/platform/RuntimeEnabledFeatures.in:75: NavigatorContentUtils
status=experimental
On 2013/12/09 07:12:55, abarth wrote:
> I'd leave the status off here.  It's not a simple status because it's shipped
on
> some platforms but not other.

As you said, I remove the "experimental" status on latest patch.

[abarth-chromium, 2013-12-09 07:36:05]

lgtm

[commit-bot: I haz the power, 2013-12-09 07:36:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/91313002/160001

[commit-bot: I haz the power, 2013-12-09 09:09:54]

Change committed as 163413