Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 913123005: Reauth causes a MergeSession, so the cookie jar gets re-authed too. (Closed)

Created:
5 years, 10 months ago by Mike Lerman
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reauth causes a MergeSession, so the cookie jar gets re-authed too. BUG=456905 Committed: https://crrev.com/2f79b7da1f9e0665c3e38516aa8c84819bf18ec7 Cr-Commit-Position: refs/heads/master@{#316290}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Existential existence check #

Patch Set 3 : pre-review checkup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -12 lines) Patch
M chrome/browser/ui/webui/signin/inline_login_handler_impl.cc View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M components/signin/core/browser/signin_manager.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M components/signin/core/browser/signin_manager.cc View 1 1 chunk +21 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Mike Lerman
Hi Roger, Can you take a look at this CL? Thanks! Mike
5 years, 10 months ago (2015-02-11 18:50:32 UTC) #2
Roger Tawa OOO till Jul 10th
https://codereview.chromium.org/913123005/diff/1/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc File chrome/browser/ui/webui/signin/inline_login_handler_impl.cc (right): https://codereview.chromium.org/913123005/diff/1/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc#newcode178 chrome/browser/ui/webui/signin/inline_login_handler_impl.cc:178: } As discussed offline, it would be better to ...
5 years, 10 months ago (2015-02-12 14:54:38 UTC) #3
Mike Lerman
https://codereview.chromium.org/913123005/diff/1/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc File chrome/browser/ui/webui/signin/inline_login_handler_impl.cc (right): https://codereview.chromium.org/913123005/diff/1/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc#newcode178 chrome/browser/ui/webui/signin/inline_login_handler_impl.cc:178: } On 2015/02/12 14:54:38, Roger Tawa wrote: > As ...
5 years, 10 months ago (2015-02-13 19:17:07 UTC) #4
Roger Tawa OOO till Jul 10th
lgtm Thanks Mike.
5 years, 10 months ago (2015-02-13 19:44:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913123005/40001
5 years, 10 months ago (2015-02-13 19:46:42 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/24994)
5 years, 10 months ago (2015-02-13 20:46:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913123005/40001
5 years, 10 months ago (2015-02-13 20:51:50 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-13 21:18:18 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 21:19:06 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/2f79b7da1f9e0665c3e38516aa8c84819bf18ec7
Cr-Commit-Position: refs/heads/master@{#316290}

Powered by Google App Engine
This is Rietveld 408576698