Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 913123004: Make mojob.py test print a summary at the end. (Closed)

Created:
5 years, 10 months ago by viettrungluu
Modified:
5 years, 10 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make mojob.py test print a summary at the end. (Otherwise, it's not obvious if all tests passed or not. This used to be more obvious when it stopped running tests on failure.) R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/00bf3881432566ec4831133516b850919c31c401

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M mojo/tools/mojob.py View 2 chunks +17 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 10 months ago (2015-02-11 16:44:15 UTC) #1
jamesr
lgtm (I've been typing echo $? a lot lately, this'll help me out a ton)
5 years, 10 months ago (2015-02-11 16:52:19 UTC) #2
viettrungluu
5 years, 10 months ago (2015-02-11 17:19:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
00bf3881432566ec4831133516b850919c31c401 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698