Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 912983002: Use SkTHashMap in SkGlyphCache. (Closed)

Created:
5 years, 10 months ago by mtklein_C
Modified:
5 years, 10 months ago
Reviewers:
herb_g, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use SkTHashMap in SkGlyphCache. All my performance tests say this is moot, which leads me to think the glyph storage strategy is not an interesting performance bottleneck right now. Must be gathering metrics, filling glyph images and paths, or of course locking and unlocking the caches. Still todo: hook back into fMemoryUsed, measure if/how memory usage changes. COMMIT=false BUG=skia:

Patch Set 1 #

Patch Set 2 : add asserts for now. #

Patch Set 3 : simplerfy #

Patch Set 4 : Pair #

Patch Set 5 : more test #

Patch Set 6 : ns #

Patch Set 7 : seems to be working #

Patch Set 8 : delete paths, and comments #

Patch Set 9 : test more api #

Patch Set 10 : tweak #

Patch Set 11 : doesnt compile #

Patch Set 12 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -274 lines) Patch
M src/core/SkGlyphCache.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +8 lines, -32 lines 0 comments Download
M src/core/SkGlyphCache.cpp View 1 2 3 4 5 6 7 8 9 10 7 chunks +36 lines, -242 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
mtklein_C
5 years, 10 months ago (2015-02-11 23:38:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912983002/210001
5 years, 10 months ago (2015-02-12 22:27:24 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 22:27:25 UTC) #5 
Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-02-13 04:27 UTC

Powered by Google App Engine
This is Rietveld 408576698