Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 912913002: Remove unneeded dependency, forward declaration, and header include. (Closed)

Created:
5 years, 10 months ago by wtc
Modified:
5 years, 10 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unneeded dependency, forward declaration, and header include. R=dalecurtis@chromium.org,scherkus@chromium.org Committed: https://crrev.com/bb33973007788e995eec61a3d6be85b141905017 Cr-Commit-Position: refs/heads/master@{#315657}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M media/mojo/services/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M media/mojo/services/mojo_renderer_service.h View 1 chunk +0 lines, -1 line 1 comment Download
M media/mojo/services/mojo_renderer_service.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
wtc
https://codereview.chromium.org/912913002/diff/1/media/mojo/services/mojo_renderer_service.h File media/mojo/services/mojo_renderer_service.h (left): https://codereview.chromium.org/912913002/diff/1/media/mojo/services/mojo_renderer_service.h#oldcode29 media/mojo/services/mojo_renderer_service.h:29: class MojoDemuxerStreamAdapter; MojoDemuxerStreamAdapter is no longer used by this ...
5 years, 10 months ago (2015-02-10 22:02:01 UTC) #1
DaleCurtis
lgtm
5 years, 10 months ago (2015-02-10 22:11:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912913002/1
5 years, 10 months ago (2015-02-10 22:18:44 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-10 22:23:43 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 22:24:37 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bb33973007788e995eec61a3d6be85b141905017
Cr-Commit-Position: refs/heads/master@{#315657}

Powered by Google App Engine
This is Rietveld 408576698