Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: chrome/browser/devtools/devtools_sanity_browsertest.cc

Issue 912863002: [DevTools] Remote JSON requests from javascript (Chromium side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed test Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_sanity_browsertest.cc
diff --git a/chrome/browser/devtools/devtools_sanity_browsertest.cc b/chrome/browser/devtools/devtools_sanity_browsertest.cc
index 9edf3b1f3de9142e05c33ec0dd3adf20531ec0c7..df92be6a914d352865d577c5f6ec07e208740a93 100644
--- a/chrome/browser/devtools/devtools_sanity_browsertest.cc
+++ b/chrome/browser/devtools/devtools_sanity_browsertest.cc
@@ -9,11 +9,13 @@
#include "base/memory/ref_counted.h"
#include "base/path_service.h"
#include "base/prefs/pref_service.h"
+#include "base/strings/string_number_conversions.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/test_timeouts.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/devtools/browser_list_tabcontents_provider.h"
+#include "chrome/browser/devtools/device/self_device_provider.h"
#include "chrome/browser/devtools/devtools_window_testing.h"
#include "chrome/browser/extensions/extension_apitest.h"
#include "chrome/browser/extensions/extension_browsertest.h"
@@ -87,6 +89,8 @@ const char kReloadSharedWorkerTestPage[] =
const char kReloadSharedWorkerTestWorker[] =
"files/workers/debug_shared_worker_initialization.js";
+const int kRemoteDebuggingPort = 9225;
+
void RunTestFunction(DevToolsWindow* window, const char* test_name) {
std::string result;
@@ -926,7 +930,7 @@ IN_PROC_BROWSER_TEST_F(DevToolsAgentHostTest, TestAgentHostReleased) {
<< "DevToolsAgentHost is not released when the tab is closed";
}
-class RemoteDebuggingTest: public ExtensionApiTest {
+class RemoteDebuggingTest : public ExtensionApiTest {
void SetUpCommandLine(base::CommandLine* command_line) override {
ExtensionApiTest::SetUpCommandLine(command_line);
command_line->AppendSwitchASCII(switches::kRemoteDebuggingPort, "9222");
@@ -966,3 +970,19 @@ IN_PROC_BROWSER_TEST_F(DevToolsPolicyTest, PolicyTrue) {
DevToolsWindow* window = DevToolsWindow::FindDevToolsWindow(agent.get());
ASSERT_FALSE(window);
}
+
+class RemoteWebSocketTest : public DevToolsSanityTest {
+ void SetUpCommandLine(base::CommandLine* command_line) override {
+ DevToolsSanityTest::SetUpCommandLine(command_line);
+ command_line->AppendSwitchASCII(switches::kRemoteDebuggingPort,
+ base::IntToString(kRemoteDebuggingPort));
+ }
+};
+
+IN_PROC_BROWSER_TEST_F(RemoteWebSocketTest, TestWebSocket) {
+ AndroidDeviceManager::DeviceProviders device_providers;
+ device_providers.push_back(new SelfAsDeviceProvider(kRemoteDebuggingPort));
+ DevToolsAndroidBridge::Factory::GetForProfile(browser()->profile())->
+ set_device_providers_for_test(device_providers);
+ RunTest("testRemoteWebSocket", "about:blank");
+}
« no previous file with comments | « chrome/browser/devtools/devtools_embedder_message_dispatcher.cc ('k') | chrome/browser/devtools/devtools_ui_bindings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698