Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: chrome/browser/devtools/devtools_targets_ui.cc

Issue 912863002: [DevTools] Remote JSON requests from javascript (Chromium side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_targets_ui.cc
diff --git a/chrome/browser/devtools/devtools_targets_ui.cc b/chrome/browser/devtools/devtools_targets_ui.cc
index e84a602096440eaf4566f24d999713ed9523fd7e..bb8ff716a8efc58433045a7a06ff27141a3ae743 100644
--- a/chrome/browser/devtools/devtools_targets_ui.cc
+++ b/chrome/browser/devtools/devtools_targets_ui.cc
@@ -24,6 +24,7 @@
#include "content/public/browser/worker_service_observer.h"
#include "content/public/common/process_type.h"
#include "net/base/escape.h"
+#include "net/base/net_errors.h"
using content::BrowserThread;
@@ -286,6 +287,10 @@ class AdbTargetsUIHandler
scoped_refptr<content::DevToolsAgentHost> GetBrowserAgentHost(
const std::string& browser_id) override;
+ void SendJsonRequest(const std::string& browser_id,
+ const std::string& url,
+ const JsonCallback& callback) override;
+
private:
// DevToolsAndroidBridge::Listener overrides.
void DeviceListChanged(
@@ -346,6 +351,17 @@ AdbTargetsUIHandler::GetBrowserAgentHost(
return android_bridge_->GetBrowserAgentHost(it->second);
}
+void AdbTargetsUIHandler::SendJsonRequest(const std::string& browser_id,
+ const std::string& url,
+ const JsonCallback& callback) {
+ RemoteBrowsers::iterator it = remote_browsers_.find(browser_id);
+ if (it == remote_browsers_.end()) {
+ callback.Run(net::ERR_FAILED, std::string());
+ } else {
+ android_bridge_->SendJsonRequest(it->second, url, callback);
+ }
+}
+
void AdbTargetsUIHandler::DeviceListChanged(
const DevToolsAndroidBridge::RemoteDevices& devices) {
remote_browsers_.clear();
@@ -460,6 +476,12 @@ DevToolsTargetsUIHandler::GetBrowserAgentHost(const std::string& browser_id) {
return NULL;
}
+void DevToolsTargetsUIHandler::SendJsonRequest(const std::string& browser_id,
+ const std::string& url,
+ const JsonCallback& callback) {
+ callback.Run(net::ERR_FAILED, std::string());
+}
+
base::DictionaryValue* DevToolsTargetsUIHandler::Serialize(
const DevToolsTargetImpl& target) {
base::DictionaryValue* target_data = new base::DictionaryValue();

Powered by Google App Engine
This is Rietveld 408576698