[DevTools] Remote JSON requests from javascript (Chromium side)

[DevTools] Remote JSON requests from javascript (Chromium side)

BUG=

Committed: https://crrev.com/00700c38f70e29ab78ad5ec4770745e524891a79
Cr-Commit-Position: refs/heads/master@{#320926}

[vkuzkokov, 2015-02-10 16:53:12]

Patchset #1 (id:1) has been deleted

[vkuzkokov, 2015-02-10 16:58:20]

Patchset #1 (id:20001) has been deleted

[vkuzkokov, 2015-02-10 17:33:54]

vkuzkokov@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2015-02-12 10:20:36]

This is looking fine, but there is too much in this patch (and also too much
style noise). You should split this into two.

https://codereview.chromium.org/912863002/diff/40001/chrome/browser/devtools/...
File chrome/browser/devtools/devtools_ui_bindings.cc (right):

https://codereview.chromium.org/912863002/diff/40001/chrome/browser/devtools/...
chrome/browser/devtools/devtools_ui_bindings.cc:489:
CallClientFunction("DevToolsAPI.embedderMessageAck",
You should make a separate function for this, e.g. |SendEmbedderMessageAck|.

[vkuzkokov, 2015-02-27 14:00:05]

https://codereview.chromium.org/912863002/diff/40001/chrome/browser/devtools/...
File chrome/browser/devtools/devtools_ui_bindings.cc (right):

https://codereview.chromium.org/912863002/diff/40001/chrome/browser/devtools/...
chrome/browser/devtools/devtools_ui_bindings.cc:489:
CallClientFunction("DevToolsAPI.embedderMessageAck",
On 2015/02/12 10:20:36, dgozman wrote:
> You should make a separate function for this, e.g. |SendEmbedderMessageAck|.

Done.

[vkuzkokov, 2015-03-06 12:29:00]

Patchset #4 (id:100001) has been deleted

[dgozman, 2015-03-06 14:00:32]

https://codereview.chromium.org/912863002/diff/120001/chrome/browser/devtools...
File chrome/browser/devtools/devtools_ui_bindings.cc (right):

https://codereview.chromium.org/912863002/diff/120001/chrome/browser/devtools...
chrome/browser/devtools/devtools_ui_bindings.cc:785:
remote_targets_handler_->SendJsonRequest(browser_id, url,
Use DevToolsAndroidBridge directly.

[vkuzkokov, 2015-03-11 16:34:03]

https://codereview.chromium.org/912863002/diff/120001/chrome/browser/devtools...
File chrome/browser/devtools/devtools_ui_bindings.cc (right):

https://codereview.chromium.org/912863002/diff/120001/chrome/browser/devtools...
chrome/browser/devtools/devtools_ui_bindings.cc:785:
remote_targets_handler_->SendJsonRequest(browser_id, url,
On 2015/03/06 14:00:32, dgozman wrote:
> Use DevToolsAndroidBridge directly.

Done.

[dgozman, 2015-03-12 12:45:27]

lgtm

https://codereview.chromium.org/912863002/diff/140001/chrome/browser/devtools...
File chrome/browser/devtools/device/devtools_android_bridge.cc (right):

https://codereview.chromium.org/912863002/diff/140001/chrome/browser/devtools...
chrome/browser/devtools/device/devtools_android_bridge.cc:685: size_t colon_pos
= browser_id_str.find(':');
Please extract this into separate BrowserIdFromString method.

https://codereview.chromium.org/912863002/diff/140001/chrome/browser/devtools...
File chrome/browser/devtools/devtools_ui_bindings.h (right):

https://codereview.chromium.org/912863002/diff/140001/chrome/browser/devtools...
chrome/browser/devtools/devtools_ui_bindings.h:143: void JsonReceived(const
DispatchCallback& callback,
nit: please move this method below, so one doesn't think it is from
DevToolsEmbedderMessageDispatcher::Delegate.

[vkuzkokov, 2015-03-12 14:20:12]

https://codereview.chromium.org/912863002/diff/140001/chrome/browser/devtools...
File chrome/browser/devtools/device/devtools_android_bridge.cc (right):

https://codereview.chromium.org/912863002/diff/140001/chrome/browser/devtools...
chrome/browser/devtools/device/devtools_android_bridge.cc:685: size_t colon_pos
= browser_id_str.find(':');
On 2015/03/12 12:45:27, dgozman wrote:
> Please extract this into separate BrowserIdFromString method.

Done.

https://codereview.chromium.org/912863002/diff/140001/chrome/browser/devtools...
File chrome/browser/devtools/devtools_ui_bindings.h (right):

https://codereview.chromium.org/912863002/diff/140001/chrome/browser/devtools...
chrome/browser/devtools/devtools_ui_bindings.h:143: void JsonReceived(const
DispatchCallback& callback,
On 2015/03/12 12:45:27, dgozman wrote:
> nit: please move this method below, so one doesn't think it is from
> DevToolsEmbedderMessageDispatcher::Delegate.

Done.

[vkuzkokov, 2015-03-13 12:33:42]

The CQ bit was checked by vkuzkokov@chromium.org

[vkuzkokov, 2015-03-13 12:33:42]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/912863002/#ps180001
(title: "Rebased")

[commit-bot: I haz the power, 2015-03-13 12:33:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/912863002/180001

[commit-bot: I haz the power, 2015-03-13 12:52:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-13 12:52:46]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[vkuzkokov, 2015-03-13 12:53:52]

vkuzkokov@chromium.org changed reviewers:
+ tsepez@chromium.org

[vkuzkokov, 2015-03-13 12:53:52]

tsepez, PTAL:
chrome/browser/devtools/devtools_embedder_message_dispatcher.*

[Tom Sepez, 2015-03-13 21:38:24]

lgtm

[vkuzkokov, 2015-03-17 14:47:39]

The CQ bit was checked by vkuzkokov@chromium.org

[vkuzkokov, 2015-03-17 14:47:40]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/912863002/#ps200001
(title: "Fixed test")

[commit-bot: I haz the power, 2015-03-17 14:47:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/912863002/200001

[commit-bot: I haz the power, 2015-03-17 16:04:23]

Committed patchset #8 (id:200001)

[commit-bot: I haz the power, 2015-03-17 16:05:21]

Patchset 8 (id:??) landed as
https://crrev.com/00700c38f70e29ab78ad5ec4770745e524891a79
Cr-Commit-Position: refs/heads/master@{#320926}