Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 912833003: Make SNaN verification universal for all arches. (Closed)

Created:
5 years, 10 months ago by dusmil.imgtec
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make SNaN verification universal for all arches. The mips HW prior to revision 5 has opposite encoding for NaNs. TEST=mjsunit/regress/*, regress-1167, regress-undefined-nan2 BUG= Committed: https://crrev.com/85ed0097d5c6efad770bf562a50992e6a204b815 Cr-Commit-Position: refs/heads/master@{#26568}

Patch Set 1 #

Patch Set 2 : Fix names. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M src/objects-debug.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
dusmil.imgtec
5 years, 10 months ago (2015-02-10 17:54:02 UTC) #2
paul.l...
LGTM, but this one needs v8 team review.
5 years, 10 months ago (2015-02-10 17:56:46 UTC) #3
Benedikt Meurer
Hm, I'm not sure I fully understand the idea... doesn't that mean that kHoleNanInt64 is ...
5 years, 10 months ago (2015-02-10 18:41:37 UTC) #4
dusmil.imgtec
Yes, the kHoleNanInt64 is quiet Nan on MIPS, but everything is working well regarding hole ...
5 years, 10 months ago (2015-02-10 19:52:54 UTC) #5
Benedikt Meurer
I'm worried that this will break at some point... so I'd strongly encourage you to ...
5 years, 10 months ago (2015-02-11 08:37:59 UTC) #6
Benedikt Meurer
lgtm
5 years, 10 months ago (2015-02-11 08:38:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912833003/20001
5 years, 10 months ago (2015-02-11 08:38:23 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-11 09:05:21 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 09:05:36 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/85ed0097d5c6efad770bf562a50992e6a204b815
Cr-Commit-Position: refs/heads/master@{#26568}

Powered by Google App Engine
This is Rietveld 408576698