Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: Source/modules/webaudio/AudioBufferSourceNode.h

Issue 912803005: Looping AudioBufferSourceNodes stop only if duration is explicitly given. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webaudio/AudioBufferSourceNode.h
diff --git a/Source/modules/webaudio/AudioBufferSourceNode.h b/Source/modules/webaudio/AudioBufferSourceNode.h
index 0d4d4517c83ffc59afe0431f184d4f587274c13e..42fa0bb457fac3f34b9191ac2d941aff01527f94 100644
--- a/Source/modules/webaudio/AudioBufferSourceNode.h
+++ b/Source/modules/webaudio/AudioBufferSourceNode.h
@@ -98,6 +98,8 @@ public:
private:
AudioBufferSourceNode(AudioContext*, float sampleRate);
+ void startSource(double when, double grainOffset, double grainDuration, bool durationGiven, ExceptionState&);
hongchan 2015/02/12 18:36:58 Can |durationGiven| be |isDurationGiven|?
Raymond Toy 2015/02/13 20:07:06 Done.
+
// Returns true on success.
bool renderFromBuffer(AudioBus*, unsigned destinationFrameOffset, size_t numberOfFrames);
@@ -132,7 +134,8 @@ private:
bool m_isGrain;
double m_grainOffset; // in seconds
double m_grainDuration; // in seconds
-
+ // True if grainDuration is given explicitly (via 3 arg start method).
+ bool m_explicitDuration;
hongchan 2015/02/12 18:36:58 Can this be |m_isDurationGiven|?
Raymond Toy 2015/02/13 20:07:06 Done.
// totalPitchRate() returns the instantaneous pitch rate (non-time preserving).
// It incorporates the base pitch rate, any sample-rate conversion factor from the buffer, and any doppler shift from an associated panner node.
double totalPitchRate();

Powered by Google App Engine
This is Rietveld 408576698