Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
912783003:
Upstream CRBProtocolObserver (Closed)
|
Created:
5 years, 10 months ago by stuartmorgan Modified:
5 years, 10 months ago CC:
chromium-reviews, erikwright+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpstream CRBProtocolObserver
Upstreams an iOS helper class for managing lists of observers using an
ObjC protocol.
BUG=None
Committed: https://crrev.com/4733f55258edf84d56745b6550611c1a0a8c61fd
Cr-Commit-Position: refs/heads/master@{#316401}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Add missing override #Patch Set 3 : Rebase #Patch Set 4 : Remove redundant virtual #
Messages
Total messages: 36 (16 generated)
stuartmorgan@chromium.org changed reviewers: + mark@chromium.org, rohitaro@chromium.org
Rohit for ios/ Mark for gyp*
stuartmorgan@chromium.org changed reviewers: + rohitrao@chromium.org - rohitaro@chromium.org
lgtm
LGTM https://codereview.chromium.org/912783003/diff/1/base/ios/crb_protocol_observ... File base/ios/crb_protocol_observers.h (right): https://codereview.chromium.org/912783003/diff/1/base/ios/crb_protocol_observ... base/ios/crb_protocol_observers.h:1: // Copyright 2014 The Chromium Authors. All rights reserved. 2015
https://codereview.chromium.org/912783003/diff/1/base/ios/crb_protocol_observ... File base/ios/crb_protocol_observers.h (right): https://codereview.chromium.org/912783003/diff/1/base/ios/crb_protocol_observ... base/ios/crb_protocol_observers.h:1: // Copyright 2014 The Chromium Authors. All rights reserved. On 2015/02/10 23:21:24, Mark Mentovai wrote: > 2015 We're upstreaming existing files; I thought we weren't supposed to thrash dates on files any more?
This didn’t look like thrash to me because I’ve never seen this file before. 2014 or 2015, then.
The CQ bit was checked by stuartmorgan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912783003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_rel_device_ninja_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
The CQ bit was checked by stuartmorgan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912783003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_rel_device_ninja_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
New patchsets have been uploaded after l-g-t-m from rohitrao@chromium.org,mark@chromium.org
The CQ bit was checked by stuartmorgan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912783003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng...)
The CQ bit was checked by stuartmorgan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912783003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
The CQ bit was checked by stuartmorgan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912783003/40001
The CQ bit was unchecked by stuartmorgan@chromium.org
The CQ bit was checked by stuartmorgan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912783003/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
The CQ bit was checked by stuartmorgan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912783003/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/4733f55258edf84d56745b6550611c1a0a8c61fd Cr-Commit-Position: refs/heads/master@{#316401} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
