ui/file_manager/file_manager/foreground/js/thumbnail_loader.js - Issue 912783002: Integrate ListThumbnailLoader to list view and grid view.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/thumbnail_loader.js

Issue 912783002: Integrate ListThumbnailLoader to list view and grid view. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add index property to thumbnail loaded event. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js ('K') | « ui/file_manager/file_manager/foreground/js/main_scripts.js ('k') | ui/file_manager/file_manager/foreground/js/ui/file_grid.js » ('j') | ui/file_manager/file_manager/foreground/js/ui/file_grid.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/thumbnail_loader.js

diff --git a/ui/file_manager/file_manager/foreground/js/thumbnail_loader.js b/ui/file_manager/file_manager/foreground/js/thumbnail_loader.js

index 83d3b391649c95c01529d11b29bd548b7ad45c6e..2d6aaff509455dbac35c4e79ed958ac4da47ccf3 100644

--- a/ui/file_manager/file_manager/foreground/js/thumbnail_loader.js

+++ b/ui/file_manager/file_manager/foreground/js/thumbnail_loader.js

@@ -252,7 +252,7 @@ ThumbnailLoader.prototype.load = function(box, fillMode, opt_optimizationMode,

* which is resolved when data url is fetched.

ThumbnailLoader.prototype.loadAsDataUrl = function() {

- return new Promise(function(resolve) {

+ return new Promise(function(resolve, reject) {

// Load by using ImageLoaderClient.

var modificationTime = this.metadata_ &&

this.metadata_.filesystem &&

@@ -260,7 +260,12 @@ ThumbnailLoader.prototype.loadAsDataUrl = function() {

this.metadata_.filesystem.modificationTime.getTime();

ImageLoaderClient.getInstance().load(

this.thumbnailUrl_,

- resolve,

+ function(result) {

+ if (result.status === 'success')

+ resolve(result);

+ else

+ reject(result);

+ },

{

maxWidth: ThumbnailLoader.THUMBNAIL_MAX_WIDTH,

maxHeight: ThumbnailLoader.THUMBNAIL_MAX_HEIGHT,