Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 912783002: Integrate ListThumbnailLoader to list view and grid view. (Closed)

Created:
5 years, 10 months ago by yawano
Modified:
5 years, 10 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Integrate ListThumbnailLoader to list view and grid view. This CL also contains following fixes. * Add error handling to ThumbnailLoader.loadAsDataUrl. * Removed unnecessary document argument from ListThumbnailLoader. BUG=438050 TEST=manually tested;Open a folder which contains photos in it with list view and grid view. Committed: https://crrev.com/e3ef182d6c4a760249728211a4278a1b224c4b50 Cr-Commit-Position: refs/heads/master@{#316185}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Add rate limiter to setHighPriorityRange. #

Patch Set 3 : Add TODO. #

Patch Set 4 : Rebase. #

Patch Set 5 : Remove unnecessary code. #

Patch Set 6 : Add index property to thumbnail loaded event. #

Total comments: 9

Patch Set 7 : Fixed animation in grid view. #

Patch Set 8 : Add FileListTable. #

Total comments: 4

Patch Set 9 : Fix comment. #

Patch Set 10 : Rebase. #

Total comments: 2

Patch Set 11 : Fix nits. #

Patch Set 12 : Fix failed test case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+313 lines, -113 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 2 3 4 5 6 7 8 9 4 chunks +17 lines, -14 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/compiled_resources.gyp View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/directory_model.js View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js View 1 2 3 4 5 6 7 9 chunks +62 lines, -24 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.js View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/main_scripts.js View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/thumbnail_loader.js View 2 chunks +7 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_grid.js View 1 2 3 4 5 6 7 8 9 10 10 chunks +96 lines, -58 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_table.js View 1 2 3 4 5 6 7 8 9 10 4 chunks +83 lines, -12 lines 0 comments Download
A ui/file_manager/file_manager/foreground/js/ui/file_table_list.js View 1 2 3 4 5 6 7 8 1 chunk +29 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/list_container.js View 1 2 3 3 chunks +10 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/main.html View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (5 generated)
yawano
Sorry for a large CL. PTAL. Thank you!
5 years, 10 months ago (2015-02-10 10:34:18 UTC) #2
fukino
Thanks! - Please add TEST in description. How can we verify this patch? - It ...
5 years, 10 months ago (2015-02-10 14:46:14 UTC) #3
yawano
Sorry for missing test description. PTAL. Thank you! https://codereview.chromium.org/912783002/diff/1/ui/file_manager/file_manager/foreground/js/ui/file_table.js File ui/file_manager/file_manager/foreground/js/ui/file_table.js (right): https://codereview.chromium.org/912783002/diff/1/ui/file_manager/file_manager/foreground/js/ui/file_table.js#newcode375 ui/file_manager/file_manager/foreground/js/ui/file_table.js:375: FileTable.prototype.onScroll_ ...
5 years, 10 months ago (2015-02-12 03:28:50 UTC) #4
yawano
Added index property to thumbnail loaded event, and use it in onThumbnailLoaded. PTAL. Thank you!
5 years, 10 months ago (2015-02-12 05:16:57 UTC) #5
fukino
Thank you! https://codereview.chromium.org/912783002/diff/100001/ui/file_manager/file_manager/foreground/css/file_manager.css File ui/file_manager/file_manager/foreground/css/file_manager.css (right): https://codereview.chromium.org/912783002/diff/100001/ui/file_manager/file_manager/foreground/css/file_manager.css#newcode812 ui/file_manager/file_manager/foreground/css/file_manager.css:812: background-position: center; nit: posision < size in ...
5 years, 10 months ago (2015-02-12 07:25:01 UTC) #6
fukino
https://codereview.chromium.org/912783002/diff/100001/ui/file_manager/file_manager/foreground/js/ui/file_grid.js File ui/file_manager/file_manager/foreground/js/ui/file_grid.js (left): https://codereview.chromium.org/912783002/diff/100001/ui/file_manager/file_manager/foreground/js/ui/file_grid.js#oldcode225 ui/file_manager/file_manager/foreground/js/ui/file_grid.js:225: * @param {boolean} animation Whther to use fadein animation ...
5 years, 10 months ago (2015-02-12 07:35:16 UTC) #7
yawano
Thank you for the review! PTAL. https://codereview.chromium.org/912783002/diff/100001/ui/file_manager/file_manager/foreground/css/file_manager.css File ui/file_manager/file_manager/foreground/css/file_manager.css (right): https://codereview.chromium.org/912783002/diff/100001/ui/file_manager/file_manager/foreground/css/file_manager.css#newcode812 ui/file_manager/file_manager/foreground/css/file_manager.css:812: background-position: center; On ...
5 years, 10 months ago (2015-02-12 09:38:24 UTC) #8
yawano
Added FileTableList. PTAL. Thank you!
5 years, 10 months ago (2015-02-13 02:14:26 UTC) #9
fukino
Thank you! lgtm with nits. https://codereview.chromium.org/912783002/diff/140001/ui/file_manager/file_manager/foreground/js/ui/file_grid.js File ui/file_manager/file_manager/foreground/js/ui/file_grid.js (right): https://codereview.chromium.org/912783002/diff/140001/ui/file_manager/file_manager/foreground/js/ui/file_grid.js#newcode104 ui/file_manager/file_manager/foreground/js/ui/file_grid.js:104: if (this.beginIndex_ < this.endIndex_) ...
5 years, 10 months ago (2015-02-13 04:49:43 UTC) #10
yawano
Thank you for the review! https://codereview.chromium.org/912783002/diff/140001/ui/file_manager/file_manager/foreground/js/ui/file_grid.js File ui/file_manager/file_manager/foreground/js/ui/file_grid.js (right): https://codereview.chromium.org/912783002/diff/140001/ui/file_manager/file_manager/foreground/js/ui/file_grid.js#newcode104 ui/file_manager/file_manager/foreground/js/ui/file_grid.js:104: if (this.beginIndex_ < this.endIndex_) ...
5 years, 10 months ago (2015-02-13 05:21:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912783002/200001
5 years, 10 months ago (2015-02-13 05:23:02 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/24682)
5 years, 10 months ago (2015-02-13 06:26:07 UTC) #16
yawano
I forgot to also change constructor call in test after I changed interface of ListThumbnailLoader ...
5 years, 10 months ago (2015-02-13 07:03:15 UTC) #17
fukino
On 2015/02/13 07:03:15, yawano wrote: > I forgot to also change constructor call in test ...
5 years, 10 months ago (2015-02-13 07:31:27 UTC) #18
yawano
On 2015/02/13 07:31:27, fukino wrote: > On 2015/02/13 07:03:15, yawano wrote: > > I forgot ...
5 years, 10 months ago (2015-02-13 07:32:00 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912783002/220001
5 years, 10 months ago (2015-02-13 07:32:28 UTC) #21
commit-bot: I haz the power
Committed patchset #12 (id:220001)
5 years, 10 months ago (2015-02-13 07:35:18 UTC) #22
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 07:35:58 UTC) #23
Message was sent while issue was closed.
Patchset 12 (id:??) landed as
https://crrev.com/e3ef182d6c4a760249728211a4278a1b224c4b50
Cr-Commit-Position: refs/heads/master@{#316185}

Powered by Google App Engine
This is Rietveld 408576698