Correctly pointer-align code cache payload.

Correctly pointer-align code cache payload.

R=jochen@chromium.org

Committed: https://crrev.com/bee9a0accb0d32d80b1d22bf68a4028ac1a7c573
Cr-Commit-Position: refs/heads/master@{#26541}

[jochen (gone - plz use gerrit), 2015-02-10 09:00:22]

https://codereview.chromium.org/912763002/diff/1/src/serialize.h
File src/serialize.h (right):

https://codereview.chromium.org/912763002/diff/1/src/serialize.h#newcode924
src/serialize.h:924: static const int kHeaderSize = (kPayloadLengthOffset + 1) *
sizeof(uint32_t);
if it's supposed to be pointer aligned, why not sizeof(void*)?

[Yang, 2015-02-10 10:12:12]

On 2015/02/10 09:00:22, jochen (slow) wrote:
> https://codereview.chromium.org/912763002/diff/1/src/serialize.h
> File src/serialize.h (right):
> 
> https://codereview.chromium.org/912763002/diff/1/src/serialize.h#newcode924
> src/serialize.h:924: static const int kHeaderSize = (kPayloadLengthOffset + 1)
*
> sizeof(uint32_t);
> if it's supposed to be pointer aligned, why not sizeof(void*)?

This is not the point where we require alignment. Header slots are uint32_t
values. After the header slots, we have variable length uint32_t slots for
reservation sizes and code stub keys. After that comes the payload, which I want
to align for checksumming.

I now changed the offsets to be actual offsets instead of slot index. It now
resembles the way we define offsets for heap objects.

[jochen (gone - plz use gerrit), 2015-02-10 10:13:10]

lgtm

[Yang, 2015-02-10 10:14:24]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-02-10 10:14:55]

New patchsets have been uploaded after l-g-t-m from jochen@chromium.org

[Yang, 2015-02-10 10:15:30]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2015-02-10 10:16:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/912763002/20001

[commit-bot: I haz the power, 2015-02-10 10:35:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-10 10:35:35]

Try jobs failed on following builders:
  v8_linux64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/2815)

[Yang, 2015-02-10 10:50:33]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2015-02-10 10:51:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/912763002/40001

[commit-bot: I haz the power, 2015-02-10 11:20:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-10 11:20:53]

Patchset 3 (id:??) landed as
https://crrev.com/bee9a0accb0d32d80b1d22bf68a4028ac1a7c573
Cr-Commit-Position: refs/heads/master@{#26541}