Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9373)

Unified Diff: content/browser/service_worker/embedded_worker_test_helper.h

Issue 912753002: Stop Service Workers that execute JavaScript for too long. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase? Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/embedded_worker_test_helper.h
diff --git a/content/browser/service_worker/embedded_worker_test_helper.h b/content/browser/service_worker/embedded_worker_test_helper.h
index 6640d853fd6bfef62a52443a48f1d41026958d30..914096b30cd9dabf53a10f64571fd011b77d6cd6 100644
--- a/content/browser/service_worker/embedded_worker_test_helper.h
+++ b/content/browser/service_worker/embedded_worker_test_helper.h
@@ -90,7 +90,7 @@ class EmbeddedWorkerTestHelper : public IPC::Sender,
// On*Event handlers. Called by the default implementation of
// OnMessageToWorker when events are sent to the embedded
// worker. By default they just return success via
- // SimulateSendReplyToBrowser.
+ // SimulateSend.
virtual void OnActivateEvent(int embedded_worker_id, int request_id);
virtual void OnInstallEvent(int embedded_worker_id,
int request_id,
@@ -111,6 +111,8 @@ class EmbeddedWorkerTestHelper : public IPC::Sender,
EmbeddedWorkerRegistry* registry();
+ int next_thread_id_;
kinuko 2015/02/10 09:15:51 nit: could we have a simple method like GetNextThr
+
private:
void OnStartWorkerStub(const EmbeddedWorkerMsg_StartWorker_Params& params);
void OnResumeAfterDownloadStub(int embedded_worker_id);
@@ -128,7 +130,6 @@ class EmbeddedWorkerTestHelper : public IPC::Sender,
IPC::TestSink sink_;
IPC::TestSink inner_sink_;
- int next_thread_id_;
int mock_render_process_id_;
// Updated each time MessageToWorker message is received.

Powered by Google App Engine
This is Rietveld 408576698