Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 912663002: Filter out Android header files from gyp targets for non-Android platforms. (Closed)

Created:
5 years, 10 months ago by jam
Modified:
5 years, 10 months ago
Reviewers:
no sievers
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Filter out Android header files from gyp targets for non-Android platforms. This improves analyze.py so that it doesn't think that an Android header change should build/test non-Android targets. BUG=455394 Committed: https://crrev.com/d9c2c62b9d8cafd29b3194816092eed6bde096b5 Cr-Commit-Position: refs/heads/master@{#315619}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/filename_rules.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jam
5 years, 10 months ago (2015-02-10 01:44:22 UTC) #2
no sievers
lgtm!
5 years, 10 months ago (2015-02-10 18:31:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912663002/1
5 years, 10 months ago (2015-02-10 18:46:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-10 19:48:11 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 19:49:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9c2c62b9d8cafd29b3194816092eed6bde096b5
Cr-Commit-Position: refs/heads/master@{#315619}

Powered by Google App Engine
This is Rietveld 408576698