Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 912633002: NaCl docs: clarify Chrome apps instead of packaged apps (Closed)

Created:
5 years, 10 months ago by JF
Modified:
5 years, 10 months ago
Reviewers:
bradnelson, binji
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl docs: clarify Chrome apps instead of packaged apps R= binji@chromium.org, bradnelson@chromium.org BUG= none Committed: https://crrev.com/f67a7e57e634224c7c9db4879db9f56da11ab38c Cr-Commit-Position: refs/heads/master@{#315608}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add link to 'choosing'. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -133 lines) Patch
M native_client_sdk/doc_generated/devguide/devcycle/dynamic-loading.html View 1 1 chunk +18 lines, -17 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/devcycle/running.html View 1 5 chunks +24 lines, -19 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/distributing.html View 5 chunks +17 lines, -19 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/tutorial/tutorial-part2.html View 2 chunks +2 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/faq.html View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/doc_generated/sdk/examples.html View 1 2 1 chunk +9 lines, -10 lines 0 comments Download
M native_client_sdk/doc_generated/sdk/release-notes.html View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/doc_generated/sitemap.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/doc/devguide/devcycle/dynamic-loading.rst View 1 2 chunks +20 lines, -18 lines 0 comments Download
M native_client_sdk/src/doc/devguide/devcycle/running.rst View 1 1 chunk +9 lines, -3 lines 0 comments Download
M native_client_sdk/src/doc/devguide/distributing.rst View 6 chunks +14 lines, -15 lines 0 comments Download
M native_client_sdk/src/doc/devguide/tutorial/tutorial-part2.rst View 2 chunks +2 lines, -4 lines 0 comments Download
M native_client_sdk/src/doc/faq.rst View 1 2 1 chunk +4 lines, -5 lines 0 comments Download
M native_client_sdk/src/doc/sdk/examples.rst View 1 2 1 chunk +10 lines, -11 lines 0 comments Download
M native_client_sdk/src/doc/sdk/release-notes.rst View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
JF
5 years, 10 months ago (2015-02-09 23:55:11 UTC) #1
binji
lgtm https://codereview.chromium.org/912633002/diff/1/native_client_sdk/src/doc/devguide/devcycle/dynamic-loading.rst File native_client_sdk/src/doc/devguide/devcycle/dynamic-loading.rst (right): https://codereview.chromium.org/912633002/diff/1/native_client_sdk/src/doc/devguide/devcycle/dynamic-loading.rst#newcode321 native_client_sdk/src/doc/devguide/devcycle/dynamic-loading.rst:321: * **hosted application:** all modules are hosted together ...
5 years, 10 months ago (2015-02-10 17:49:40 UTC) #2
JF
https://codereview.chromium.org/912633002/diff/1/native_client_sdk/src/doc/devguide/devcycle/dynamic-loading.rst File native_client_sdk/src/doc/devguide/devcycle/dynamic-loading.rst (right): https://codereview.chromium.org/912633002/diff/1/native_client_sdk/src/doc/devguide/devcycle/dynamic-loading.rst#newcode321 native_client_sdk/src/doc/devguide/devcycle/dynamic-loading.rst:321: * **hosted application:** all modules are hosted together on ...
5 years, 10 months ago (2015-02-10 18:26:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912633002/20001
5 years, 10 months ago (2015-02-10 18:38:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/57330) ios_rel_device_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 10 months ago (2015-02-10 18:42:38 UTC) #8
JF
On 2015/02/10 18:42:38, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 10 months ago (2015-02-10 18:46:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912633002/40001
5 years, 10 months ago (2015-02-10 18:48:50 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-10 19:09:32 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 19:10:20 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/f67a7e57e634224c7c9db4879db9f56da11ab38c
Cr-Commit-Position: refs/heads/master@{#315608}

Powered by Google App Engine
This is Rietveld 408576698