Get rid of PreParserScope.

Get rid of PreParserScope.

It's unnecessary; PreParser can just use normal Scopes for the things it needs
to track. Note: the only functionalities of PreParserScope were keeping track of
the scope stack, and for each scope, the scope type and language mode. Those are
now done by Scope. PreParser doesn't yet put variables into scopes (that will be
done in a follow up).

R=rossberg@chromium.org
BUG=

Committed: https://crrev.com/0ca9bef37fba0bbf408addf9ef3bf9e58ec8cc13
Cr-Commit-Position: refs/heads/master@{#26544}

[marja, 2015-02-10 13:05:39]

rossberg, ptal

https://codereview.chromium.org/912563004/diff/1/src/preparser.cc
File src/preparser.cc (right):

https://codereview.chromium.org/912563004/diff/1/src/preparser.cc#newcode1011
src/preparser.cc:1011: // scope_->SetScopeName(name);
This will be fixed when PreParser starts to handle identifiers etc. as
AstString*s. Setting the scope name of PreParserScope didn't do anything, so
commenting this out doesn't remove any functionality...

[rossberg, 2015-02-10 13:11:26]

LGTM

Always nice to see when making something more general actually simplifies code.
:)

[marja, 2015-02-10 13:12:23]

The CQ bit was checked by marja@chromium.org

[commit-bot: I haz the power, 2015-02-10 13:12:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/912563004/1

[commit-bot: I haz the power, 2015-02-10 13:27:16]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-10 13:27:41]

Patchset 1 (id:??) landed as
https://crrev.com/0ca9bef37fba0bbf408addf9ef3bf9e58ec8cc13
Cr-Commit-Position: refs/heads/master@{#26544}

[arv (Not doing code reviews), 2015-02-10 14:46:42]

arv@chromium.org changed reviewers:
+ arv@chromium.org

[arv (Not doing code reviews), 2015-02-10 14:46:42]

LGTM. This is great.