Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 912533003: Fix ChromeSwitchCompat thumb drawable and tint color (Closed)

Created:
5 years, 10 months ago by Theresa
Modified:
5 years, 10 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ChromeSwitchCompat thumb drawable and tint color This is a temporary workaround until we can roll the support library with their fixes for these issues. BUG=455327 Committed: https://crrev.com/5e62781dabadaf144659e957932ec1f32fe3b078 Cr-Commit-Position: refs/heads/master@{#315434}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Changes from newt's review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -0 lines) Patch
A chrome/android/java/res/color/switch_thumb_tint.xml View 1 1 chunk +14 lines, -0 lines 0 comments Download
A + chrome/android/java/res/drawable-hdpi/btn_switch_to_on_mtrl_00001.9.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-hdpi/btn_switch_to_on_mtrl_00012.9.png View Binary file 0 comments Download
A chrome/android/java/res/drawable/switch_thumb.xml View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/ChromeSwitchCompat.java View 1 3 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Theresa
5 years, 10 months ago (2015-02-09 21:24:37 UTC) #2
newt (away)
https://codereview.chromium.org/912533003/diff/1/chrome/android/java/res/color/switch_thumb_tint.xml File chrome/android/java/res/color/switch_thumb_tint.xml (right): https://codereview.chromium.org/912533003/diff/1/chrome/android/java/res/color/switch_thumb_tint.xml#newcode2 chrome/android/java/res/color/switch_thumb_tint.xml:2: <!-- Copyright 2014 The Chromium Authors. All rights reserved. ...
5 years, 10 months ago (2015-02-09 21:38:05 UTC) #3
Theresa
ptal https://codereview.chromium.org/912533003/diff/1/chrome/android/java/res/color/switch_thumb_tint.xml File chrome/android/java/res/color/switch_thumb_tint.xml (right): https://codereview.chromium.org/912533003/diff/1/chrome/android/java/res/color/switch_thumb_tint.xml#newcode2 chrome/android/java/res/color/switch_thumb_tint.xml:2: <!-- Copyright 2014 The Chromium Authors. All rights ...
5 years, 10 months ago (2015-02-09 23:01:15 UTC) #4
newt (away)
lgtm
5 years, 10 months ago (2015-02-09 23:07:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912533003/20001
5 years, 10 months ago (2015-02-09 23:11:03 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-09 23:32:28 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 23:33:09 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5e62781dabadaf144659e957932ec1f32fe3b078
Cr-Commit-Position: refs/heads/master@{#315434}

Powered by Google App Engine
This is Rietveld 408576698