Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issue 912503003: Remove "nacl_defines" from the GYP build. (Closed)

Created:
5 years, 10 months ago by teravest
Modified:
5 years, 10 months ago
Reviewers:
Mark Seaborn, jamesr, Nico
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, Nick Bray (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove "nacl_defines" from the GYP build. The following NaCl-related defines are now provided by native_client/src/include/build_config.h instead of the build system: NACL_WINDOWS NACL_LINUX NACL_OSX NACL_ANDROID NACL_BUILD_ARCH NACL_BUILD_SUBARCH This change removes these definitions from gyp(i) files, as they no longer need to be provided by the build system. BUG=440012 Committed: https://crrev.com/83538d2ebdbfab63c9d7a875405663ea91672259 Cr-Commit-Position: refs/heads/master@{#315429}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -148 lines) Patch
M chrome/chrome.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -8 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M components/nacl.gyp View 7 chunks +0 lines, -28 lines 0 comments Download
D components/nacl/nacl_defines.gypi View 1 chunk +0 lines, -75 lines 0 comments Download
M mojo/mojo_nacl.gyp View 4 chunks +0 lines, -10 lines 0 comments Download
M mojo/mojo_nacl_untrusted.gyp View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
teravest
5 years, 10 months ago (2015-02-09 20:29:11 UTC) #2
Mark Seaborn
Nice. LGTM. Do the changes to mojo/ need to be copied into the Mojo repo?
5 years, 10 months ago (2015-02-09 20:42:09 UTC) #3
teravest
On 2015/02/09 20:42:09, Mark Seaborn wrote: > Nice. LGTM. > > Do the changes to ...
5 years, 10 months ago (2015-02-09 20:48:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912503003/1
5 years, 10 months ago (2015-02-09 21:25:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/41507)
5 years, 10 months ago (2015-02-09 21:33:04 UTC) #8
teravest
+jamesr for mojo/ +thakis for chrome/chrome.gyp
5 years, 10 months ago (2015-02-09 21:37:26 UTC) #10
jamesr
lgtm
5 years, 10 months ago (2015-02-09 21:38:46 UTC) #11
Nico
lgtm
5 years, 10 months ago (2015-02-09 21:40:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912503003/1
5 years, 10 months ago (2015-02-09 21:42:47 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 23:28:42 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 23:29:25 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83538d2ebdbfab63c9d7a875405663ea91672259
Cr-Commit-Position: refs/heads/master@{#315429}

Powered by Google App Engine
This is Rietveld 408576698