Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 912493003: Add key_mobile_sites_cycler.py that contains page sets that does not do scrolling. (Closed)

Created:
5 years, 10 months ago by nednguyen
Modified:
5 years, 10 months ago
Reviewers:
sullivan, dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add key_mobile_sites_cycler.py that contains page sets that does not do scrolling. This is needed so that page_cycler's action_name_to_run's field can later be changed from empty string to 'RunPageInteractions'. BUG=418375 Committed: https://crrev.com/aae1c580bc0fb6596d9daf0210a0b1fa56118e6c Cr-Commit-Position: refs/heads/master@{#315433}

Patch Set 1 #

Patch Set 2 : Fix typo in key_mobile_sites_cycler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -97 lines) Patch
M tools/perf/benchmarks/page_cycler.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/perf/page_sets/data/key_mobile_sites_cycler.json View 1 chunk +49 lines, -49 lines 0 comments Download
A + tools/perf/page_sets/key_mobile_sites_cycler.py View 1 4 chunks +41 lines, -47 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
nednguyen
5 years, 10 months ago (2015-02-09 18:41:50 UTC) #2
sullivan
lgtm
5 years, 10 months ago (2015-02-09 20:10:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912493003/1
5 years, 10 months ago (2015-02-09 20:45:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/30658)
5 years, 10 months ago (2015-02-09 22:01:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912493003/20001
5 years, 10 months ago (2015-02-09 22:14:11 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-09 23:31:26 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 23:32:33 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aae1c580bc0fb6596d9daf0210a0b1fa56118e6c
Cr-Commit-Position: refs/heads/master@{#315433}

Powered by Google App Engine
This is Rietveld 408576698