Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 912413003: Make the statistics generation data driven. (Closed)

Created:
5 years, 10 months ago by Daniel Bratell
Modified:
5 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make the statistics generation data driven. StatisticsExtension::GetCounters() has grown to repeat a lot of code so to make it more maintainable and generate less machine code, make it data driven. This makes a 64 bit Linux build 50 KB smaller. Total change: -51677 bytes ========================== 1 shrunk, for a net change of -51677 bytes (64222 bytes before, 12545 bytes after) across 1 sources 279691 unchanged, totalling 51423668 bytes Per-source Analysis: ------------------------------------------------------------------------------------------------------------------- -51677 - Source: /home/bratell/src/chromium/src/v8/src/extensions/statistics-extension.cc - (gained 0, lost 51677) ------------------------------------------------------------------------------------------------------------------- Shrunk symbols: -51677: v8::internal::StatisticsExtension::GetCounters(v8::FunctionCallbackInfo<v8::Value> const&) type=t, (was 64222 bytes, now 12545 bytes) BUG= Committed: https://crrev.com/cc36222776172588ddb6c396fc09e53f4ba86d76 Cr-Commit-Position: refs/heads/master@{#26640}

Patch Set 1 #

Patch Set 2 : s/int/size_t/ to not get compiler warnings. #

Patch Set 3 : intptr_t #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -73 lines) Patch
M src/extensions/statistics-extension.cc View 1 2 1 chunk +68 lines, -73 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Daniel Bratell
svenpanne, can you please take a look? I'm sorry about the format of the code ...
5 years, 10 months ago (2015-02-11 16:05:12 UTC) #2
Sven Panne
lgtm
5 years, 10 months ago (2015-02-13 08:00:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912413003/1
5 years, 10 months ago (2015-02-13 08:00:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/2974) v8_linux_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 10 months ago (2015-02-13 08:02:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912413003/20001
5 years, 10 months ago (2015-02-13 09:47:34 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/2891)
5 years, 10 months ago (2015-02-13 09:49:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912413003/40001
5 years, 10 months ago (2015-02-13 10:36:55 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-13 10:56:47 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 10:57:21 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cc36222776172588ddb6c396fc09e53f4ba86d76
Cr-Commit-Position: refs/heads/master@{#26640}

Powered by Google App Engine
This is Rietveld 408576698