src/gpu/effects/GrDisableColorXP.h - Issue 912413002: Pass in ProcOptInfos into willNeedDstCopy on XPs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/effects/GrDisableColorXP.h

Issue 912413002: Pass in ProcOptInfos into willNeedDstCopy on XPs (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Review cleanup Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/effects/GrDisableColorXP.h

diff --git a/src/gpu/effects/GrDisableColorXP.h b/src/gpu/effects/GrDisableColorXP.h

index fef0f1ee3b2a8a272e76e823dd484ed6285c6579..fe60b595a0c7140796e31f522085e376e9d78ef3 100644

--- a/src/gpu/effects/GrDisableColorXP.h

+++ b/src/gpu/effects/GrDisableColorXP.h

@@ -43,7 +43,10 @@ private:

const GrProcOptInfo& coveragePOI,

const GrDeviceCoordTexture* dstCopy) const SK_OVERRIDE;

- bool willReadDstColor() const SK_OVERRIDE { return false; }

+ bool willReadDstColor(const GrProcOptInfo& colorPOI,

+ const GrProcOptInfo& coveragePOI) const SK_OVERRIDE {

+ return false;

+ }

bool onIsEqual(const GrXPFactory& xpfBase) const SK_OVERRIDE {

return true;