Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1615)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 912403004: Remove SkPictureFlat.h include from SkDrawCommands.h (Closed)

Created:
5 years, 10 months ago by robertphillips
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SkPictureFlat.h include from SkDrawCommands.h This cannot land until https://codereview.chromium.org/909353004/ (Prepare SkiaBenchmarkingExtensionTest for upcoming Skia changes) lands in Chromium Committed: https://skia.googlesource.com/skia/+/5a4c233a3657d12d836de388b41e30405b4ab976 Committed: https://skia.googlesource.com/skia/+/fa3a83d0fe53907e618346d3f1c17a95da1a9d22 Committed: https://skia.googlesource.com/skia/+/9bafc30c7900375d316d47e24412ddfd8bd0b1f2

Patch Set 1 #

Patch Set 2 : Fix lingering uses of old enum #

Patch Set 3 : Update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -319 lines) Patch
M debugger/SkDebugger.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 2 chunks +20 lines, -18 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 2 chunks +7 lines, -14 lines 0 comments Download
M src/utils/debugger/SkDrawCommand.h View 1 2 7 chunks +61 lines, -67 lines 0 comments Download
M src/utils/debugger/SkDrawCommand.cpp View 1 2 33 chunks +88 lines, -134 lines 0 comments Download
M tools/filtermain.cpp View 1 10 chunks +43 lines, -82 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
robertphillips
5 years, 10 months ago (2015-02-11 17:54:00 UTC) #2
reed1
lgtm
5 years, 10 months ago (2015-02-11 17:56:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912403004/1
5 years, 10 months ago (2015-02-11 17:57:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/1985)
5 years, 10 months ago (2015-02-11 17:59:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912403004/20001
5 years, 10 months ago (2015-02-11 18:20:55 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/5a4c233a3657d12d836de388b41e30405b4ab976
5 years, 10 months ago (2015-02-11 18:27:34 UTC) #11
robertphillips
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/917933002/ by robertphillips@google.com. ...
5 years, 10 months ago (2015-02-11 21:06:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912403004/40001
5 years, 10 months ago (2015-02-12 19:44:55 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912403004/40001
5 years, 10 months ago (2015-02-12 20:30:35 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/fa3a83d0fe53907e618346d3f1c17a95da1a9d22
5 years, 10 months ago (2015-02-12 20:30:45 UTC) #18
robertphillips
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/923753002/ by robertphillips@google.com. ...
5 years, 10 months ago (2015-02-12 21:28:01 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912403004/40001
5 years, 10 months ago (2015-02-13 19:10:45 UTC) #21
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 19:13:04 UTC) #22
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/9bafc30c7900375d316d47e24412ddfd8bd0b1f2

Powered by Google App Engine
This is Rietveld 408576698