Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Issue 912403003: X87: Propagate Deopt reason to cpu-profiler (Closed)

Created:
5 years, 10 months ago by chunyang.dai
Modified:
5 years, 10 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Propagate Deopt reason to cpu-profiler port 86cae1633caa31f2225b6932850fb13d3a21cf59 (r26545) original commit message: 1) Deoptimizer::Reason was replaced with Deoptimizer::DeoptInfo because it also has raw position. Also the old name clashes with DeoptReason enum. 2) c_entry_fp assignment call was added to EntryGenerator::Generate So we can calculate sp and have a chance to record the stack for the deopting function. btw it makes the test stable. 3) new kind of CodeEvents was added to cpu-profiler 4) GetDeoptInfo method was extracted from PrintDeoptLocation. So it could be reused in cpu profiler. BUG= R=weiliang.lin@intel.com Committed: https://chromium.googlesource.com/v8/v8/+/4c345754b108302a4de5ad003cdc3fb10377b652

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/x87/deoptimizer-x87.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL. thanks
5 years, 10 months ago (2015-02-11 15:35:05 UTC) #2
Weiliang
lgtm
5 years, 10 months ago (2015-02-11 15:36:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912403003/20001
5 years, 10 months ago (2015-02-11 15:37:25 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/4c345754b108302a4de5ad003cdc3fb10377b652 Cr-Commit-Position: refs/heads/master@{#26588}
5 years, 10 months ago (2015-02-11 15:37:40 UTC) #6
chunyang.dai
5 years, 10 months ago (2015-02-11 15:37:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4c345754b108302a4de5ad003cdc3fb10377b652 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698