compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java - Issue 9124006: Blacklist types from core library, issue 969

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java

Issue 9124006: Blacklist types from core library, issue 969 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Use Set for checking type names. Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/Elements.java ('k') | compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java b/compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java

index 74f5475e144b85ce9fa2a13cc826608c4e420619..b431b7c60af0334e9340d0a328995e01ecee5a5c 100644

--- a/compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java

+++ b/compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java

@@ -201,10 +201,10 @@ public class ResolutionContext implements ResolutionErrorListener {

isFactory,

errorCode);

case NONE:

- if (identifier.toString().equals("void")) {

+ if (Elements.isIdentifierName(identifier, "void")) {

return typeProvider.getVoidType();

}

- if (identifier.toString().equals("Dynamic")) {

+ if (Elements.isIdentifierName(identifier, "Dynamic")) {

return typeProvider.getDynamicType();

}

break;