src/compiler/value-numbering-reducer.cc - Issue 912393002: Mark some common operator with Property::kNoThrow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/value-numbering-reducer.cc

Issue 912393002: Mark some common operator with Property::kNoThrow. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix GVN failures. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/value-numbering-reducer.cc

diff --git a/src/compiler/value-numbering-reducer.cc b/src/compiler/value-numbering-reducer.cc

index 734b3e8e8ee870f04b500e2f784849d95dd77505..5e924d7a303434fd6ddaee4e3e0870d8c78cbf1f 100644

--- a/src/compiler/value-numbering-reducer.cc

+++ b/src/compiler/value-numbering-reducer.cc

@@ -50,7 +50,7 @@ ValueNumberingReducer::~ValueNumberingReducer() {}

Reduction ValueNumberingReducer::Reduce(Node* node) {

- if (!node->op()->HasProperty(Operator::kEliminatable)) return NoChange();

+ if (!node->op()->HasProperty(Operator::kIdempotent)) return NoChange();

const size_t hash = HashCode(node);

if (!entries_) {

« no previous file with comments | « src/compiler/pipeline.cc ('k') | test/unittests/compiler/common-operator-unittest.cc » ('j') | no next file with comments »