Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 912393002: Mark some common operator with Property::kNoThrow. (Closed)

Created:
5 years, 10 months ago by Michael Starzinger
Modified:
5 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Mark some common operator with Property::kNoThrow. R=bmeurer@chromium.org TEST=unittests/CommonOperatorTest Committed: https://crrev.com/ec4305e48beb3fa16291ba0f3a67d8194e7af87f Cr-Commit-Position: refs/heads/master@{#26584}

Patch Set 1 #

Patch Set 2 : Fix GVN failures. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -63 lines) Patch
M src/compiler/common-operator.cc View 1 9 chunks +45 lines, -47 lines 0 comments Download
M src/compiler/operator.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/value-numbering-reducer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/common-operator-unittest.cc View 1 4 chunks +7 lines, -7 lines 0 comments Download
M test/unittests/compiler/value-numbering-reducer-unittest.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 10 months ago (2015-02-11 13:23:41 UTC) #1
Benedikt Meurer
lgtm
5 years, 10 months ago (2015-02-11 14:46:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912393002/20001
5 years, 10 months ago (2015-02-11 14:53:55 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-11 15:02:35 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 15:02:52 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ec4305e48beb3fa16291ba0f3a67d8194e7af87f
Cr-Commit-Position: refs/heads/master@{#26584}

Powered by Google App Engine
This is Rietveld 408576698