Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 912383003: ASSERTION FAILED: !m_parsedCalculation in CSSPropertyParser::parseCalculation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/Source/core/css/parser/CSSPropertyParser.cpp b/Source/core/css/parser/CSSPropertyParser.cpp
index 599d299e6335f7d45ddb302ded51cdd55ccf01a8..d25319097e7e05e5519176ae8fd3f92950f1f560 100644
--- a/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/Source/core/css/parser/CSSPropertyParser.cpp
@@ -5554,7 +5554,8 @@ PassRefPtrWillBeRawPtr<CSSValueList> CSSPropertyParser::parseShadow(CSSParserVal
return nullptr;
// Blur radius must be non-negative.
- if (context.allowBlur && !validUnit(val, FLength | FNonNeg, HTMLStandardMode))
+ if (context.allowBlur && ((m_parsedCalculation && m_parsedCalculation->isNegative())
+ || !validUnit(val, FLength | FNonNeg, HTMLStandardMode)))
rune 2015/02/18 19:09:54 Won't this still hit the assert for positive calc
return nullptr;
// A length is allowed here. Construct the value and add it.

Powered by Google App Engine
This is Rietveld 408576698