Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 9123030: Split NumberDictionary into a randomly seeded and an unseeded (Closed)

Created:
8 years, 11 months ago by Erik Corry
Modified:
7 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Split NumberDictionary into a randomly seeded and an unseeded version. We don't want to randomize the stub cache.

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+369 lines, -228 lines) Patch
M src/arm/macro-assembler-arm.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M src/code-stubs.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/elements.cc View 1 6 chunks +10 lines, -9 lines 0 comments Download
M src/factory.h View 1 2 chunks +12 lines, -3 lines 0 comments Download
M src/factory.cc View 1 2 chunks +26 lines, -6 lines 0 comments Download
M src/heap.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M src/heap.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M src/incremental-marking.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M src/objects.h View 1 6 chunks +54 lines, -17 lines 0 comments Download
M src/objects.cc View 1 39 chunks +152 lines, -89 lines 0 comments Download
M src/objects-debug.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/objects-inl.h View 1 5 chunks +16 lines, -18 lines 0 comments Download
M src/profile-generator.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/runtime.cc View 1 12 chunks +31 lines, -26 lines 0 comments Download
M src/stub-cache.cc View 1 10 chunks +21 lines, -14 lines 0 comments Download
M src/type-info.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/type-info.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/v8globals.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Erik Corry
8 years, 11 months ago (2012-01-13 13:15:54 UTC) #1
Mads Ager (chromium)
I see nothing wrong with the change. The templates seem heavy to achieve the typing ...
8 years, 11 months ago (2012-01-13 13:53:38 UTC) #2
Erik Corry
8 years, 11 months ago (2012-01-14 01:39:47 UTC) #3
On 2012/01/13 13:53:38, Mads Sig Ager wrote:
> I see nothing wrong with the change. The templates seem heavy to achieve the
> typing benefit. Can we create two subclasses instead. Everything is shared
> except for the hash functions. Then you get the typing benefit that way
without
> the templates and the duplication they lead to?

OK, here's a new code review with the other approach:

http://codereview.chromium.org/9174023

I agree the non-template version is prettier, though there is a little more
textual code duplication.

Powered by Google App Engine
This is Rietveld 408576698