Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 912273003: update sampleapp for stroking experiment (Closed)

Created:
5 years, 10 months ago by caryclark
Modified:
5 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

update sampleapp for stroking experiment Add RotateCircles3 back as better-named QuadStroker. Switch pathfill test to call skia before draw instead of in initializer to avoid triggering debugging breakpoints. Committed: https://skia.googlesource.com/skia/+/88c748aeea1cedfc8280d7f3da3d949ed01be177

Patch Set 1 #

Patch Set 2 : fix number truncation errors #

Patch Set 3 : fix another number truncation error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+541 lines, -7 lines) Patch
M gm/pathfill.cpp View 2 chunks +4 lines, -7 lines 0 comments Download
M gyp/SampleApp.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A samplecode/SampleQuadStroker.cpp View 1 2 1 chunk +536 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912273003/1
5 years, 10 months ago (2015-02-18 13:50:40 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-18 13:50:42 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/2539)
5 years, 10 months ago (2015-02-18 13:55:22 UTC) #6
reed1
lgtm
5 years, 10 months ago (2015-02-18 14:23:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912273003/40001
5 years, 10 months ago (2015-02-18 14:45:41 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 18:56:04 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/88c748aeea1cedfc8280d7f3da3d949ed01be177

Powered by Google App Engine
This is Rietveld 408576698