Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 912273002: Fix wrong lib directory for x64 and mips64el target. (Closed)

Created:
5 years, 10 months ago by haltonhuo
Modified:
5 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix wrong lib directory for x64 and mips64el target. Linker report incompatible target errors on crtbegin_so.o and crtend_so.o because /usr/lib is set incorrectly on x64 target. mips64el is also changed and arm64 keep use /usr/lib after checking each platform ndk toolchains but not verified because no environment. BUG=none Committed: https://crrev.com/964602788cc2d0a2b0cb89fcbe1691852d25f251 Cr-Commit-Position: refs/heads/master@{#316128}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/toolchain/android/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
haltonhuo
PTAL
5 years, 10 months ago (2015-02-11 06:08:02 UTC) #2
brettw
lgtm
5 years, 10 months ago (2015-02-12 18:45:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912273002/1
5 years, 10 months ago (2015-02-13 01:33:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-13 02:01:31 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 02:02:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/964602788cc2d0a2b0cb89fcbe1691852d25f251
Cr-Commit-Position: refs/heads/master@{#316128}

Powered by Google App Engine
This is Rietveld 408576698