Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: media/base/key_systems.h

Issue 912233004: Explicitly differentiate key system support functions by EME version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/android/webmediaplayer_android.cc ('k') | media/base/key_systems.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/key_systems.h
diff --git a/media/base/key_systems.h b/media/base/key_systems.h
index d761abf2c66a3cc1391754588b1a71bfce2b43cc..73eca6f486361c6c994d03e8e97c4379783006e7 100644
--- a/media/base/key_systems.h
+++ b/media/base/key_systems.h
@@ -35,6 +35,8 @@ MEDIA_EXPORT bool IsSaneInitDataTypeWithContainer(
const std::string& init_data_type,
const std::string& container);
+// Use for unprefixed EME only!
+// Returns whether |key_system| is a supported key system.
// Note: Shouldn't be used for prefixed API as the original
// IsSupportedKeySystemWithMediaMimeType() path reports UMAs, but this path does
// not.
@@ -44,20 +46,24 @@ MEDIA_EXPORT bool IsSupportedKeySystemWithInitDataType(
const std::string& key_system,
const std::string& init_data_type);
+// Use for prefixed EME only!
// Returns whether |key_system| is a real supported key system that can be
// instantiated.
// Abstract parent |key_system| strings will return false.
// Call IsSupportedKeySystemWithMediaMimeType() to determine whether a
// |key_system| supports a specific type of media or to check parent key
// systems.
-MEDIA_EXPORT bool IsConcreteSupportedKeySystem(const std::string& key_system);
+MEDIA_EXPORT bool PrefixedIsSupportedConcreteKeySystem(
+ const std::string& key_system);
+// Use for unprefixed EME only!
// Returns whether |key_system| supports the specified media type and codec(s).
MEDIA_EXPORT bool IsSupportedKeySystemWithMediaMimeType(
const std::string& mime_type,
const std::vector<std::string>& codecs,
const std::string& key_system);
+// Use for prefixed EME only!
// Returns whether |key_system| supports the specified media type and codec(s).
// To be used with prefixed EME only as it generates UMAs based on the query.
MEDIA_EXPORT bool PrefixedIsSupportedKeySystemWithMediaMimeType(
« no previous file with comments | « content/renderer/media/android/webmediaplayer_android.cc ('k') | media/base/key_systems.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698