Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 912233004: Explicitly differentiate key system support functions by EME version. (Closed)

Created:
5 years, 10 months ago by ddorwin
Modified:
5 years, 10 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly differentiate key system support functions by EME version. Committed: https://crrev.com/fa1ac9537d8f6a5a02fe3fdc37280bf1b6799786 Cr-Commit-Position: refs/heads/master@{#316683}

Patch Set 1 #

Patch Set 2 : Fully qualify some #include paths. #

Patch Set 3 : Fix Windows build. #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -66 lines) Patch
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/key_systems.h View 2 chunks +7 lines, -1 line 0 comments Download
M media/base/key_systems.cc View 1 2 9 chunks +18 lines, -17 lines 0 comments Download
M media/base/key_systems_unittest.cc View 13 chunks +82 lines, -40 lines 0 comments Download
M media/blink/encrypted_media_player_support.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/blink/webcontentdecryptionmodule_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/blink/webencryptedmediaclient_impl.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
ddorwin
5 years, 10 months ago (2015-02-12 01:27:46 UTC) #3
sandersd (OOO until July 31)
lgtm
5 years, 10 months ago (2015-02-17 19:57:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912233004/60001
5 years, 10 months ago (2015-02-17 20:02:02 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_rel_tests_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tests_recipe/builds/2504)
5 years, 10 months ago (2015-02-17 21:44:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912233004/60001
5 years, 10 months ago (2015-02-17 21:50:07 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-17 22:41:33 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 22:42:17 UTC) #12
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/fa1ac9537d8f6a5a02fe3fdc37280bf1b6799786
Cr-Commit-Position: refs/heads/master@{#316683}

Powered by Google App Engine
This is Rietveld 408576698