Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 912233003: X87: new classes: implement new.target passing to superclass constructor (Closed)

Created:
5 years, 10 months ago by chunyang.dai
Modified:
5 years, 10 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: new classes: implement new.target passing to superclass constructor port bf49be39f333bf1ce14202663595d455aa4b24cb (r26572) original commit message: new classes: implement new.target passing to superclass constructor BUG= Committed: https://crrev.com/8be79b005df2e17a1431f282344e71ec24fc3ff3 Cr-Commit-Position: refs/heads/master@{#26596}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -8 lines) Patch
M src/x87/builtins-x87.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 5 chunks +18 lines, -3 lines 0 comments Download
M src/x87/deoptimizer-x87.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x87/full-codegen-x87.cc View 4 chunks +18 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL. thanks
5 years, 10 months ago (2015-02-11 17:09:13 UTC) #2
Weiliang
lgtm
5 years, 10 months ago (2015-02-11 17:12:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912233003/1
5 years, 10 months ago (2015-02-11 17:12:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-11 17:41:57 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 17:42:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8be79b005df2e17a1431f282344e71ec24fc3ff3
Cr-Commit-Position: refs/heads/master@{#26596}

Powered by Google App Engine
This is Rietveld 408576698