Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Issue 912223002: Revert of GYP groudwork for half-float opts support. (Closed)

Created:
5 years, 10 months ago by mtklein
Modified:
5 years, 10 months ago
Reviewers:
mtklein_C, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of GYP groudwork for half-float opts support. (patchset #1 id:1 of https://codereview.chromium.org/915693002/) Reason for revert: Going to punt on 16-bit float support for now. Can't figure out ARM 64. Original issue's description: > GYP groudwork for half-float opts support. > > This sets us up two new opts targets with the immediate goal of adding half-float (SkHalf.h) opts: > - opts_neon_fp16: uses hardware support on most ARM chips with NEON to do 4 conversions at a time; > - opts_avx: uses hardware support on Intel chips with AVX to do 8 conversions at a time. > > opts_avx will be a handy thing to have around later too, especially if we want to work with floats. > > This doesn't actually add any new source files to these libraries yet, so they're no-ops for now. > I'll need to write a parallel change to Chrome's GN and GYPs before we can start adding sources. > > This also rolls GYP up to head, to get suppport for EnableEnhancedInstructionSet: '3' on Windows, > which is how we turn on AVX there. There's no Mac-specific flag, so we use OTHER_CPLUSPLUSFLAGS. > > BUG=skia: > > TBR=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/46b80833394d7919cadf2abf2b93802141dd21c5 TBR=reed@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/d160192fd9bab3c81d2dc40dbed41cdd7d660988

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -49 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M gyp/opts.gyp View 4 chunks +1 line, -44 lines 0 comments Download
M gyp/opts.gypi View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of GYP groudwork for half-float opts support.
5 years, 10 months ago (2015-02-11 02:17:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912223002/1
5 years, 10 months ago (2015-02-11 02:18:14 UTC) #2
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 02:18:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d160192fd9bab3c81d2dc40dbed41cdd7d660988

Powered by Google App Engine
This is Rietveld 408576698