Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: sky/engine/core/html/HTMLIFrameElement.cpp

Issue 912183002: Adds support for embedViewManagerClient() to IFrame. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/html/HTMLIFrameElement.cpp
diff --git a/sky/engine/core/html/HTMLIFrameElement.cpp b/sky/engine/core/html/HTMLIFrameElement.cpp
index 90cb6736f57358dd1fe885f96848cec0e621206e..372c9a9d2cb01355ac8ffec73bb286b1ec148b05 100644
--- a/sky/engine/core/html/HTMLIFrameElement.cpp
+++ b/sky/engine/core/html/HTMLIFrameElement.cpp
@@ -80,6 +80,15 @@ ScriptValue HTMLIFrameElement::takeExposedServicesHandle(ScriptState* scriptStat
return ScriptValue(scriptState, gin::ConvertToV8(scriptState->isolate(), m_exposedServices.release()));
}
+void HTMLIFrameElement::embedViewManagerClient(blink::ScriptValue client) {
+ if (!m_contentView)
+ return;
+
+ mojo::MessagePipeHandle handle;
+ if (gin::ConvertFromV8(client.isolate(), client.v8Value(), &handle))
+ m_contentView->Embed(mojo::MakeProxy<mojo::ViewManagerClient>(mojo::MakeScopedHandle(handle).Pass()));
abarth-chromium 2015/02/11 01:02:13 Is the Pass() needed here? It looks redundant.
hansmuller1 2015/02/11 01:09:00 Done.
+}
+
void HTMLIFrameElement::navigateView()
{
if (!m_contentView)

Powered by Google App Engine
This is Rietveld 408576698