Adds support for embedViewManagerClient() to IFrame.

Adds support for embedViewManagerClient() to IFrame.

R=abarth@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/b431c268019b5dec77a0e73adcfc090c847b5adb

[hansmuller1, 2015-02-11 00:57:43]

hansmuller@google.com changed reviewers:
+ abarth@chromium.org

[hansmuller1, 2015-02-11 00:58:13]

hansmuller@google.com changed reviewers:
+ hansmuller@google.com

[hansmuller1, 2015-02-11 00:58:13]

PTAL

[abarth-chromium, 2015-02-11 01:02:13]

Neat!

LGTM

https://codereview.chromium.org/912183002/diff/1/sky/engine/core/html/HTMLIFr...
File sky/engine/core/html/HTMLIFrameElement.cpp (right):

https://codereview.chromium.org/912183002/diff/1/sky/engine/core/html/HTMLIFr...
sky/engine/core/html/HTMLIFrameElement.cpp:89:
m_contentView->Embed(mojo::MakeProxy<mojo::ViewManagerClient>(mojo::MakeScopedHandle(handle).Pass()));
Is the Pass() needed here?  It looks redundant.

https://codereview.chromium.org/912183002/diff/1/sky/engine/core/html/HTMLIFr...
File sky/engine/core/html/HTMLIFrameElement.h (right):

https://codereview.chromium.org/912183002/diff/1/sky/engine/core/html/HTMLIFr...
sky/engine/core/html/HTMLIFrameElement.h:31: void
embedViewManagerClient(blink::ScriptValue client);
No need for blink::

also, const ScriptValue&

https://codereview.chromium.org/912183002/diff/1/sky/tests/services/iframe-em...
File sky/tests/services/iframe-embed-vmc.sky (right):

https://codereview.chromium.org/912183002/diff/1/sky/tests/services/iframe-em...
sky/tests/services/iframe-embed-vmc.sky:11: <iframe src="about:blank"></iframe>
You can skip the src.  It defaults to about:blank

[hansmuller1, 2015-02-11 01:09:01]

Thanks for the speedy review delivery!

https://codereview.chromium.org/912183002/diff/1/sky/engine/core/html/HTMLIFr...
File sky/engine/core/html/HTMLIFrameElement.cpp (right):

https://codereview.chromium.org/912183002/diff/1/sky/engine/core/html/HTMLIFr...
sky/engine/core/html/HTMLIFrameElement.cpp:89:
m_contentView->Embed(mojo::MakeProxy<mojo::ViewManagerClient>(mojo::MakeScopedHandle(handle).Pass()));
On 2015/02/11 01:02:13, abarth wrote:
> Is the Pass() needed here?  It looks redundant.

Done.

https://codereview.chromium.org/912183002/diff/1/sky/engine/core/html/HTMLIFr...
File sky/engine/core/html/HTMLIFrameElement.h (right):

https://codereview.chromium.org/912183002/diff/1/sky/engine/core/html/HTMLIFr...
sky/engine/core/html/HTMLIFrameElement.h:31: void
embedViewManagerClient(blink::ScriptValue client);
On 2015/02/11 01:02:13, abarth wrote:
> No need for blink::
> 
> also, const ScriptValue&

Done.

https://codereview.chromium.org/912183002/diff/1/sky/tests/services/iframe-em...
File sky/tests/services/iframe-embed-vmc.sky (right):

https://codereview.chromium.org/912183002/diff/1/sky/tests/services/iframe-em...
sky/tests/services/iframe-embed-vmc.sky:11: <iframe src="about:blank"></iframe>
On 2015/02/11 01:02:13, abarth wrote:
> You can skip the src.  It defaults to about:blank

Done.

[hansmuller, 2015-02-11 01:09:31]

Committed patchset #1 (id:1) manually as
b431c268019b5dec77a0e73adcfc090c847b5adb (presubmit successful).