Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 912123002: Revert of Enable sanitizer default options for 32-bit CrOS (Closed)

Created:
5 years, 10 months ago by girard
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable sanitizer default options for 32-bit CrOS (patchset #1 id:1 of https://codereview.chromium.org/899973006/) Reason for revert: x86-ASAN is breaking: see http://build.chromium.org/p/chromiumos/builders/x86-generic%20ASAN/builds/20379/steps/BuildPackages/logs/stdio chromeos-chrome-42.0.2301.0_rc-r1: FAILED: clang++ -Wl,-O2 -Wl,--as-needed -Wl,-z,now -Wl,-z,relro -Wl,--fatal-warnings -pthread -Wl,-z,noexecstack -fPIC -fuse-ld=gold -Wl,-u_sanitizer_options_link_helper -m32 -Wl,-O1 -Wl,--gc-sections -o mksnapshot -Wl,--start-group obj.host/v8/src/mksnapshot.mksnapshot.o obj.host/build/sanitizers/libsanitizer_options.a obj.host/v8/tools/gyp/libv8_base.a obj.host/v8/tools/gyp/libv8_nosnapshot.a obj.host/v8/tools/gyp/libv8_libplatform.a obj.host/third_party/icu/libicui18n.a obj.host/third_party/icu/libicuuc.a obj.host/v8/tools/gyp/libv8_libbase.a obj.host/third_party/icu/libicudata.a -Wl,--end-group -lrt chromeos-chrome-42.0.2301.0_rc-r1: /usr/x86_64-pc-linux-gnu/binutils-bin/2.24/ld.gold.real: error: obj.host/build/sanitizers/libsanitizer_options.a(obj.host/build/sanitizers/sanitizer_options.sanitizer_options.o): incompatible target Original issue's description: > Enable sanitizer default options for 32-bit CrOS > > BUG=302040 > TBR=earthdok@chromium.org > > Committed: https://crrev.com/0ed000a79da1b02a8a3d095286f3e076d732f393 > Cr-Commit-Position: refs/heads/master@{#315291} TBR=earthdok@chromium.org,glider@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=302040 Committed: https://crrev.com/f33741de3f9f0730fcb879e149d1e463ed693c51 Cr-Commit-Position: refs/heads/master@{#315667}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
girard
Created Revert of Enable sanitizer default options for 32-bit CrOS
5 years, 10 months ago (2015-02-10 23:00:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912123002/1
5 years, 10 months ago (2015-02-10 23:02:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-10 23:03:01 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 23:03:46 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f33741de3f9f0730fcb879e149d1e463ed693c51
Cr-Commit-Position: refs/heads/master@{#315667}

Powered by Google App Engine
This is Rietveld 408576698