Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 912053003: Fix append_fallback_font_families_for_locale. (Closed)

Created:
5 years, 10 months ago by bungeman-skia
Modified:
5 years, 10 months ago
Reviewers:
djsollen, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix append_fallback_font_families_for_locale. The language was being set to garbage, now set to part of the file name. Add a test to ensure we continue to parse fallback directories correctly. BUG=chromium:422180 Committed: https://skia.googlesource.com/skia/+/c3c694342ad393b88cee5885395f182082aa2ebb

Patch Set 1 #

Patch Set 2 : Fix line lengths. #

Total comments: 2

Patch Set 3 : Full test and address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -39 lines) Patch
M include/core/SkTemplates.h View 1 chunk +4 lines, -0 lines 0 comments Download
A + resources/android_fonts/v17/fallback_fonts-ja.xml View 3 chunks +38 lines, -3 lines 0 comments Download
M src/ports/SkFontConfigParser_android.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/ports/SkFontConfigParser_android.cpp View 3 chunks +36 lines, -32 lines 0 comments Download
M tests/FontConfigParser.cpp View 1 2 4 chunks +24 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
bungeman-skia
5 years, 10 months ago (2015-02-10 23:59:52 UTC) #2
djsollen
lgtm I forgot that we lost this feature when we switched to the new parsing ...
5 years, 10 months ago (2015-02-11 13:34:15 UTC) #3
bungeman-skia
https://codereview.chromium.org/912053003/diff/20001/src/ports/SkFontConfigParser_android.h File src/ports/SkFontConfigParser_android.h (right): https://codereview.chromium.org/912053003/diff/20001/src/ports/SkFontConfigParser_android.h#newcode105 src/ports/SkFontConfigParser_android.h:105: const char* langFallbackFontsDir); On 2015/02/11 13:34:15, djsollen wrote: > ...
5 years, 10 months ago (2015-02-11 15:02:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912053003/40001
5 years, 10 months ago (2015-02-11 15:03:14 UTC) #7
djsollen
lgtm again
5 years, 10 months ago (2015-02-11 15:03:48 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 15:18:55 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/c3c694342ad393b88cee5885395f182082aa2ebb

Powered by Google App Engine
This is Rietveld 408576698