pkg/analyzer/lib/src/generated/resolver.dart - Issue 912023002: Use ExitDetector.exists(node).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/generated/resolver.dart

Issue 912023002: Use ExitDetector.exists(node). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/generated/resolver.dart

diff --git a/pkg/analyzer/lib/src/generated/resolver.dart b/pkg/analyzer/lib/src/generated/resolver.dart

index 5dcbcfb806ba26ffddb919f83f0b292a41d6ca49..034aa731425b3dc0bffaef2c2d97797e504d0b8c 100644

--- a/pkg/analyzer/lib/src/generated/resolver.dart

+++ b/pkg/analyzer/lib/src/generated/resolver.dart

@@ -598,7 +598,7 @@ class BestPracticesVerifier extends RecursiveAstVisitor<Object> {

}

// Check the block for a return statement, if not, create the hint

BlockFunctionBody blockFunctionBody = body as BlockFunctionBody;

- if (!blockFunctionBody.accept(new ExitDetector())) {

+ if (!ExitDetector.exits(blockFunctionBody)) {

_errorReporter.reportErrorForNode(

HintCode.MISSING_RETURN,

returnType,

« no previous file with comments | « no previous file | pkg/analyzer/test/generated/all_the_rest_test.dart » ('j') | no next file with comments »